Bug 14642: Add logging for Holds
authorTomas Cohen Arazi <tomascohen@theke.io>
Wed, 15 Jun 2016 17:48:57 +0000 (14:48 -0300)
committerKyle M Hall <kyle@bywatersolutions.com>
Wed, 17 Aug 2016 18:43:13 +0000 (18:43 +0000)
commitd1eb7061536d11b382c3256aaefb48fc447bfa72
treea942c757f5d00090cf897f4e2df90c9c5060547b
parenta6bc706ad1fac9e9343c04a9c8ac142d493629a8
Bug 14642: Add logging for Holds

This patch adds logging for several holds actions. Specifically for:

- CREATE
- CANCEL
- DELETE
- RESUME
- SUSPEND
- MODIFY

To test:
- Enable the HoldsLog syspref
- Add a hold on a record/item
=> SUCCESS: The log view shows the CREATE action
- Click on the <Suspend> button
=> SUCCESS: The log view shows the SUSPEND action
- Click on the <Unsuspend> button
=> SUCCESS: The log view shows the RESUME action
- Click on the red cross, to delete the hold
=> SUCCESS: The log view shows the CANCEL action

Note: The DELETE action is logged when DelMember is called, with bug 16819 patches applied.

Sponsored-by: NEKLS
Signed-off-by: Liz Rea <liz@catalyst.net.nz>
I also wonder about this going in defaulted on, but since the other logs are as well it seems ok to me.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
C4/Log.pm
C4/Reserves.pm
Koha/Hold.pm
koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt
opac/opac-reserve.pl