Bug 9113: fix handling of certain characters by item batch modification tool
authorFridolyn SOMERS <fridolyn.somers@biblibre.com>
Wed, 26 Jun 2013 15:52:40 +0000 (17:52 +0200)
committerChris Hall <followingthepath@gmail.com>
Sun, 18 Aug 2013 04:26:42 +0000 (16:26 +1200)
commitd4f7db74cd6edb344b0c50e77bdbaab50eacb8c3
tree6f5718062e9ba413a555af83968663facdc6db43
parent869de3235805965d0bca2d68590c376445034c79
Bug 9113: fix handling of certain characters by item batch modification tool

If you're using the batch modification tool and entering a call number
like "E+ 123 ABC", the tool removes the + and puts a space in its place,
e.g., "E  123 ABC"

This is because the form is posted via Ajax by background-job-progressbar.js.
Values are URI-encoded using escape(), but this method does not escape some
characters: * @ - _ + . /

Also, "+" is considered as a space in a URI.

This patch replaces escape() by encodeURIComponent() which encodes every character.

Test plan :
Perform an items batch modification by setting '* @ - _ + . /' in a field
(notes for example) and see that all characters are saved correctly.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit 0397e7ea64c208c140d7178ed34c3bd4b266fcfb)
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
(cherry picked from commit dbd52acf2958bca6b126a35a47d03b6d4d4d541d)
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
(cherry picked from commit dbd52acf2958bca6b126a35a47d03b6d4d4d541d)
Signed-off-by: Chris Hall <followingthepath@gmail.com>
(cherry picked from commit 70cc750a5f96ca72c07f359006730ff92f9ff5b5)
koha-tmpl/intranet-tmpl/prog/en/js/background-job-progressbar.js