Bug 32712: Fix OPAC breakage when OPACShowCheckoutName enabled
authorTomas Cohen Arazi <tomascohen@theke.io>
Mon, 30 Jan 2023 20:08:36 +0000 (17:08 -0300)
committerTomas Cohen Arazi <tomascohen@theke.io>
Tue, 31 Jan 2023 12:25:03 +0000 (09:25 -0300)
commitd74fe69d2c463078ba4c0797cdc3d01fab82bccb
tree79a0e69a18de66138f3a36f462dc1e48a989b6a2
parent8f38f3b74ba8c16d1b6da76714371312f6a8037e
Bug 32712: Fix OPAC breakage when OPACShowCheckoutName enabled

Bug 31313 removed GetItemsInfo and proper Koha::Object-based objects are
passed now. But some automatic search & replace kept patron-related
attributes incorrectly linked to Koha::Item.

This patch makes the item-status.inc file reuse the checkout object and
get the linked patron to gather the required information. Some
simplification is done on hte same patch... should be trivial.

To test:
1. Have OpacShowCheckoutName enabled
2. Pick a biblio with items (all of them not checkecd-out)
3. Open the OPAC detail view for the biblio
=> SUCCESS: You see the biblio and the items
4. Check one of the items out
5. Refresh the OPAC page
=> FAIL: The page explodes!
6. Apply this patch
7. Refresh the OPAC page
=> SUCCESS: You see the biblio and the items, the patron info is
correctly displayed.
8. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc