Bug 27058: Remove confusing and unnecessary $biblionumber1 variable
authorJoonas Kylmälä <joonas.kylmala@helsinki.fi>
Fri, 19 Feb 2021 07:49:51 +0000 (09:49 +0200)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 8 Mar 2021 14:15:49 +0000 (15:15 +0100)
commitda81064b8b8b8efc6950084231b1943f25f7820d
treea10b4c5dc8eddb42f63d5ba6d17bd24d342bf265
parent18128cc810a00a46f8d4af19bebaa4c562761456
Bug 27058: Remove confusing and unnecessary $biblionumber1 variable

The code is much more understandable now because with $biblio2 and
$biblionumber1 variables use to point to the same biblio one might
have thought $biblionumber1 points to $biblio1 which in this case is
not true. Let's just drop the extra variable because the object
notation of accessing is just as simple.

To test:
 1) prove t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t => passes

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t