Bug 35078: Remove invalid HTML from OpacShowSavings system preference
authorOwen Leonard <oleonard@myacpl.org>
Tue, 17 Oct 2023 13:51:49 +0000 (13:51 +0000)
committerFridolin Somers <fridolin.somers@biblibre.com>
Wed, 8 Nov 2023 07:11:43 +0000 (21:11 -1000)
commitdfd5562503059ede3de3e30d8fe4c853839182ac
treef105ebdec89cd87e6bc609e25008bb924de7b690
parent83b251e91d418e85d236c945e0edd52e601a7513
Bug 35078: Remove invalid HTML from OpacShowSavings system preference

The options defined for the OpacShowSavings system preference contain
HTML: "on patron's checkout history page (the system preference
<em>opacreadinghistory</em> must be enabled)". This text ends up in an
<option> tag, and even though the form is rendered using the
multiple-select plugin the HTML still won't render and should
be removed.

To test, apply the patch and restart all.

- Go to Administration -> System preferences and search for
  "OpacShowSavings"
- Check the dropdown of options on the preference. The system
  preference names referred to should now be single-quoted instead of
  wrapped in visible <em> tags.
- Confirm that the preference still works correctly.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit dc9f6f09d8d6869a41e80a496b58038c246ad6cf)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref