do some validation of the KohaOpacRecentSearches cookie
authorGalen Charlton <gmc@esilibrary.com>
Sun, 28 Jul 2013 02:48:44 +0000 (02:48 +0000)
committerTomas Cohen Arazi <tomascohen@gmail.com>
Sun, 28 Jul 2013 13:41:38 +0000 (10:41 -0300)
commite198862a718a9c05dfcab8a6c79f85b3f5d55afc
tree601820d61c07de0bc37479c3c9e7a58e174146d6
parent24a4d123e336540350221983a279354f010976fc
do some validation of the KohaOpacRecentSearches cookie

Add validation of the value of the KohaOpacRecentSearches.  In
particular, this patch avoids the generation of an internal server
error when the OPAC is presented with an old cookie that uses the
old Storable-based serialization.

This patch also moves parsing of the cookie value into a
new routine in C4::Auth, ParseSearchHistoryCookie, and adds
a test case.

To test (in conjunction with the previous patch):

Exercise the OPAC search history functionality, after
turning on the EnableOpacSearchHistory syspref:

- As an anonymous user, conduct a variety of searches,
  including ones that include non-ASCII characters
- Check the search history and verify that all searches
  are listed
- Apply this patch and the previous one.
- Do *not* clear the KohaOpacRecentSearches cookie
- Check the search history and verify that no searches
  are listed any more
- As an anonymous user, conduct a variety of searches,
  including ones that include non-ASCII characters
- Check the search history and verify that all searches
  are listed
- Log into the OPAC
- Verify that current and past searches are listed in
  search history.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit 8ea810b03089c8d3e6aed9663d277e4b2cc23d55)
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
C4/Auth.pm
opac/opac-search-history.pl
opac/opac-search.pl
t/Auth_ParseSearchHistoryCookie.t [new file with mode: 0644]