Bug 19563: (follow-up) Restore checking sort variable
authorNick Clemens <nick@bywatersolutions.com>
Fri, 17 Nov 2017 12:13:55 +0000 (12:13 +0000)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 11 Dec 2017 17:30:32 +0000 (14:30 -0300)
commite1ba8d344ddfff53d24fa6b3a1966e17bdd13a7c
tree3e58db7e536d16b29cdc10e21d24a0df6d1c4459
parentdb776c34d23ddd0d4a78e83a983d5b0c906c188a
Bug 19563: (follow-up) Restore checking sort variable

This code seems a bit odd, $self->sort_fields()->{$name} is checking if
there is any mapping in ES for a field, so if one marc field in an index
is marked as sortable this will exists. We need to check the individual
marc field to see if it should be added to the sort index here.

If you apply the first patch, reindex, and view a record in es:
curl -XGET 'localhost:9200/koha_kohadev_biblios/data/19/?pretty' | grep
-A 10 author__sort

You will see that 245$c is included in the record without that
additional check

Apply this, reindex again, and that field should not be included

Signed-off-by: David Bourgault <david.bourgault@inlibro.com>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Koha/SearchEngine/Elasticsearch.pm