Bug 18320: Remove calls to CGI->param from the templates in patron cards
authorTomas Cohen Arazi <tomascohen@theke.io>
Thu, 23 Dec 2021 20:50:33 +0000 (17:50 -0300)
committerFridolin Somers <fridolin.somers@biblibre.com>
Wed, 19 Jan 2022 22:13:49 +0000 (12:13 -1000)
commite3a98dd05c20333a4bcd64f3b3c00d58d68a347e
treeafb5cf48a62125987ee45692bd758a64380ccbe1
parentb31d1f669a0b78d642be74f11aff68e4994f4275
Bug 18320: Remove calls to CGI->param from the templates in patron cards

This patch removes calls to CGI->param from within the templates
(patroncards-errors.inc) and passes error_* variables with the same
codes from the controllers to the template instead.

This way we can be sure CGI->param is not called in list context.

To test, try those pages and see they don't show warnings anymore.
Verify that error situations still show the error messages.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
koha-tmpl/intranet-tmpl/prog/en/includes/patroncards-errors.inc
patroncards/edit-batch.pl
patroncards/image-manage.pl
patroncards/manage.pl