Bug 22862: Normalize SMS messaging numbers before validating them
authorKyle M Hall <kyle@bywatersolutions.com>
Tue, 7 May 2019 18:53:29 +0000 (14:53 -0400)
committerFridolin Somers <fridolin.somers@biblibre.com>
Wed, 24 Jul 2019 07:23:17 +0000 (09:23 +0200)
commite461daff8002466be1a662645023c9479d909f26
tree91416283ec2722b3e602b73ec6e504659a6c3dd0
parentcc036d49e19852ba54437cb97a273e1a1f1670e0
Bug 22862: Normalize SMS messaging numbers before validating them

Librarians often copy and paste patron data, including phone numbers. SMS phone numbers are now being validated to conform to the E.164 specification. It would be nice to try to normalize that data by stripping non-numeric data from the paste (i.e. dashes, parens, etc ).

Test Plan:
1) Apply this patch
2) On the staff side, Attempt to enter invalid characters the SMS number field
3) Note you cannot enter invalid characters
4) Attempt to paste a phone number with invalid characters
5) Note those characters are removed on paste
6) Repeat these steps on the OPAC

Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit 115f4f2045a6c695d1eed47cd401b7759630ac4d)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
koha-tmpl/intranet-tmpl/prog/js/members.js
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt