]> git.koha-community.org Git - koha.git/commit
Bug 17530: (QA follow-up) Move may_article_request to ItemType
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Mon, 4 Jun 2018 08:03:40 +0000 (10:03 +0200)
committerNick Clemens <nick@bywatersolutions.com>
Fri, 7 Sep 2018 13:16:08 +0000 (13:16 +0000)
commite85d6e12ea4dccd8fa08ec600864c2f985dcf886
tree76a6310a1caa5af3966e77157b18ff20e6aec032
parent8d53a1508d3fb8c6336839995f61036809ffedd2
Bug 17530: (QA follow-up) Move may_article_request to ItemType

As requested by QA, we should move may_article_request out of Biblio.

For reasons of performance removed the wrapper layer of may_article_request
in opac-search. No need to look up all item types. For readability kept
the routine in the detail scripts.

Note for running ArticleRequests.t: A possible failure on the subtest
'search_limited' is addressed on bug 20866. So you can ignore that one.
As long as the subtest for may_article_request passes.

Test plan:
See previous patches.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Koha/Biblio.pm
Koha/ItemType.pm
opac/opac-ISBDdetail.pl
opac/opac-MARCdetail.pl
opac/opac-detail.pl
opac/opac-search.pl
t/db_dependent/ArticleRequests.t