Bug 24345: Fix process of suggesting purchase of existing title for non-logged-in...
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Sun, 5 Jan 2020 21:02:18 +0000 (22:02 +0100)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Thu, 23 Jan 2020 09:08:39 +0000 (09:08 +0000)
commited5ec62cac48a96413a9e468d8bacc2a4ef80ea5
tree89ad15e0245171d17f5add98a43a99d5f50e2aff
parent991f51b27240bd5d5e2ce302db7260f17d7e680c
Bug 24345: Fix process of suggesting purchase of existing title for non-logged-in users

The 'op' parameter is removed from the CGI object ($input) before
get_template_and_user is called. When the user is redirected to the
login form (from checkauth, called from get_template_and_user), the
op is lost.

Moving down the deletion fixes the problem.

Test plan:
Logout at the OPAC
Go the detail page of a bibliographic record
Click the "Suggest for purchase" link
Fill the login form
=> Without this patch you will see your suggestion list
=> With this patch applied the new suggestion form will be displayed,
prefilled with the biblio's info

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
opac/opac-suggestions.pl