Bug 28125: Display a warning on the about page for OPACHiddenItems is needed
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 13 Apr 2021 08:47:19 +0000 (10:47 +0200)
committerFridolin Somers <fridolin.somers@biblibre.com>
Thu, 29 Apr 2021 09:18:47 +0000 (11:18 +0200)
commited67185035d190332a6feaf4828562f4d487ac5b
treebc73941d2fc094e8ebeedd609cc506151e01a9a3
parent5daf19384da413bb9b572cd9884aba97ab0e85b1
Bug 28125: Display a warning on the about page for OPACHiddenItems is needed

If OPACHiddenItems is containing badly construct it will lead to
inconsistent behaviours. For instance the holds view will not display
any items, when the detail page will display all of them (because we are
not using the same code, we are in transition to merge it).

This patch suggests to add a warning to the about page in case the query
generated by Koha::Items->filter_by_visible_in_opac produces a warning

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Bug 28125: (QA follow-up) Fix missing filter

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 71574961f7322e04e996b11f9932b2006ea93215)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
about.pl
koha-tmpl/intranet-tmpl/prog/en/modules/about.tt
t/db_dependent/Koha/Items.t