Bug 21621: Remove incorrect GROUP BY from tools/letter.pl
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Fri, 19 Oct 2018 15:06:43 +0000 (12:06 -0300)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Thu, 8 Nov 2018 15:35:17 +0000 (15:35 +0000)
commiteea7b7493506bc7d6095f41b4f02f1be357432d5
tree64c290f6da03de9917137321af232939d307da24
parent14e9eb67b9e86b025eeddc9426c490280a4c022f
Bug 21621: Remove incorrect GROUP BY from tools/letter.pl

Fix:
  'koha_kohadev.letter.name' isn't in GROUP BY

DBD::mysql::db selectall_arrayref failed: 'koha_kohadev.letter.name' isn't in GROUP BY [for Statement "SELECT branchcode, module, code, name, branchname
            FROM letter
            LEFT OUTER JOIN branches USING (branchcode)
     GROUP BY branchcode,module,code ORDER BY module, code, branchcode"] at /home/vagrant/kohaclone/tools/letter.pl line 383.

Test plan:
- Copy some default notice templates for specific libraries
- List the different notice templates
- Confirm that notices appear only one, with "all libraries" you will see all

Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit 0cffb0f7589aa52d65bda9a8a4934790a141f3a0)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
tools/letter.pl