Bug 16864: Silence warnings in t/db_dependent/ILSDI_Services.t
authorMark Tompsett <mtompset@hotmail.com>
Wed, 6 Jul 2016 18:17:20 +0000 (14:17 -0400)
committerBrendan Gallagher <brendan@bywatersolutions.com>
Thu, 4 Aug 2016 20:06:07 +0000 (20:06 +0000)
commitef0738922005e4235b80e70663d7fa711a87556e
tree4631038138186cdb20cab7c74843d942fc808f3f
parent1be7fb5e12f0dd3911bb182ef2c0740c481337ec
Bug 16864: Silence warnings in t/db_dependent/ILSDI_Services.t

prove t/db_dependent/ILSDI_Services.t
generates noisy output as a result of the ambiguous context
of two $cgi->param() calls.

By storing into scalar variables, and then using the scalar
variables, the code maintains readability and fixes the problem.

TEST PLAN
---------
1) prove t/db_dependent/ILSDI_Services.t
   -- noisy.
2) apply patch
3) prove t/db_dependent/ILSDI_Services.t
   -- not noisy
4) run koha qa test tools

Signed-off-by: Marc <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com>
C4/ILSDI/Services.pm