Bug 8216: Allow SIP modules to pass critic tests
authorColin Campbell <colin.campbell@ptfs-europe.com>
Sat, 9 Jun 2012 09:40:19 +0000 (10:40 +0100)
committerChris Cormack <chrisc@catalyst.net.nz>
Fri, 22 Jun 2012 08:12:43 +0000 (20:12 +1200)
commitef6444e302a0549f48d3da16ecbc90ea70bf5990
treeccc770597b3896ea0761d083053d561c1d64ec1f
parent4b38fb0d4346480f7acefaf3d6976952bb2307c3
Bug 8216: Allow SIP modules to pass critic tests

Add C4/SIP to perlcritic tests. Fix those issues that were
generating perlcritic errors

Signed-off-by: Stacey Walker <stacey@catalyst-eu.net>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
12 files changed:
C4/SIP/ILS/Item.pm
C4/SIP/ILS/Patron.pm
C4/SIP/ILS/Transaction/Checkout.pm
C4/SIP/ILS/Transaction/Hold.pm
C4/SIP/ILS/Transaction/Renew.pm
C4/SIP/ILS/Transaction/RenewAll.pm
C4/SIP/SIPServer.pm
C4/SIP/Sip/Checksum.pm
C4/SIP/Sip/Configuration.pm
C4/SIP/Sip/MsgType.pm
C4/SIP/t/SIPtest.pm
t/00-testcritic.t