Bug 19807: Make IntranetCatalogSearchPulldown honor IntranetNumbersPreferPhrase
authorVictor Grousset <victor.grousset@biblibre.com>
Wed, 13 Dec 2017 19:16:54 +0000 (20:16 +0100)
committerFridolin Somers <fridolin.somers@biblibre.com>
Mon, 22 Jan 2018 10:57:17 +0000 (11:57 +0100)
commitf460450c091b7bfe295c468d15a7e911c9e0b297
treef51cb74a3d0e834f4354a0bd33dc6253fda800e5
parenta4d988ffad9cf527daa229497cafe2f425d30b17
Bug 19807: Make IntranetCatalogSearchPulldown honor IntranetNumbersPreferPhrase

This patch
- fixes callnum and sn
- Removes unecessary syspref transmission to the template.
  As the template directly reads the syspref

Test plan:
1. Set sysprefs IntranetCatalogSearchPulldown and
   IntranetNumbersPreferPhrase to true
2. Go to staff:/cgi-bin/koha/catalogue/search.pl
3. "search for" → "call number" and write anything that won't match a
   call number in the field
4. Then you should see
   «No results match your search for 'callnum,phr: [...]»
5. Go to the staff homepage
6. Click on "Search the catalog"
7. Do the same search as previouly
8. Then you should see
   «No results match your search for 'callnum,wrdl: [...]»
   This shows that IntranetNumbersPreferPhrase isn't honored
9. Apply this patch
10. Redo the same two searches and see that phr will now be always used.
    So IntranetNumbersPreferPhrase is honored

Signed-off-by: Jon Knight <J.P.Knight@lboro.ac.uk>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit df899212b25250cfac412f14478e481acdd6672a)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
catalogue/search.pl
koha-tmpl/intranet-tmpl/prog/en/includes/search_indexes.inc