Bug 20167: Make changing a hold pass the itemnumber to ModReserve
authorTomas Cohen Arazi <tomascohen@gmail.com>
Mon, 5 Mar 2018 16:36:50 +0000 (13:36 -0300)
committerFridolin Somers <fridolin.somers@biblibre.com>
Tue, 27 Mar 2018 11:40:14 +0000 (13:40 +0200)
commitfa20c7a4f562bd3ff3952276f62c6b5e4e7f85c4
treedd4961d6453b0af6078306141106fab50d31657c
parent1664e8080157461db9eae73e076806f4e41e712b
Bug 20167: Make changing a hold pass the itemnumber to ModReserve

If you have an item-level hold, changing an attribute (like priority,
pickup location or suspended until date) makes the hold a biblio-level
hold, because ModReserve is not passed the current itemnumber.

This patch uses the hold's itemnumber and passes it to the ModReserve
call.

To test:
- Run the regression tests from the previous patch:
  $ kshell
 k$ prove t/db_dependent/api/v1/holds.t
=> FAIL: Tests fail
- Apply this patch
- Run the tests:
  $ kshell
 k$ prove t/db_dependent/api/v1/holds.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
(cherry picked from commit e854b570021784d8e6ce8bb9d90e0b02d6f8c9a7)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Koha/REST/V1/Hold.pm