Bug 25670: New orders included only if standing
authorTomas Cohen Arazi <tomascohen@theke.io>
Thu, 7 Jan 2021 19:16:00 +0000 (16:16 -0300)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Thu, 28 Jan 2021 15:41:10 +0000 (16:41 +0100)
commitfcd336168300b453749d5ec12355a74fd4ff57f3
tree6279459259a4324ae87bc1fa8b3fed6ba39967f3
parent52a75bba8771f2c4eec4e684970b7035b9efc761
Bug 25670: New orders included only if standing

The original implementation included new orders regardless they were
standing orders.

This patch makes the query respect that conditions found on
C4::Acquisitions::SearchOrders.

To test:
1. Apply the regression tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Acquisition/Orders.t
=> FAIL: More orders than expected are returned
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass! New orders are only considered if the basket
they are attached to, is marked as standing!
5. Verify the tests make sense
6. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Koha/Acquisition/Orders.pm