Bug 28581: Use from_email_address in the codebase
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Thu, 17 Jun 2021 09:59:18 +0000 (09:59 +0000)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 23 Jun 2021 13:09:55 +0000 (15:09 +0200)
commitfdf75e4cb0a0a7b2f2ed8694980f68d4fdc5b922
treed806c1cf4fcb5a4cd7c054371a4cd317915b996d
parenta7c202de1c97438a32b86a309a449e7c427f77d3
Bug 28581: Use from_email_address in the codebase

Adding only a few (trivial) cases now. Changes in C4::Letters
are not trivial after all..
We now add the KohaAdminEmail fallback implicitly when the from
address was still empty. The extra check makes us not rely on
a do or die action in Email::Stuffer.

Test plan:
Run password recovery or membership expiry cron.
Check sender address.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
C4/Letters.pm
Koha/Patron/Password/Recovery.pm
misc/cronjobs/automatic_renewals.pl
misc/cronjobs/membership_expiry.pl