Bug 25566: Add option to ignore found holds and use it when checking high holds
authorNick Clemens <nick@bywatersolutions.com>
Thu, 21 May 2020 13:41:23 +0000 (13:41 +0000)
committerAleisha Amohia <aleishaamohia@hotmail.com>
Thu, 30 Jul 2020 13:15:53 +0000 (01:15 +1200)
commitfe86de90479a4f6a6a52277490a83cf8e133dbba
tree5c7d6018e2adb2fd323a728d1aadf9f95a44794a
parent4bc565692778cf8521e0e8ce7ea841babe83d918
Bug 25566: Add option to ignore found holds and use it when checking high holds

To test:
 1 - Find or create a record with 10 items
 2 - Set sysprefs:
     decreaseLoanHighHolds - enable
     decreaseLoanHighHoldsDuration - 2
     decreaseLoanHighHoldsValue - 2
     decreaseLoanHighHoldsControl  - 'over the number of holdable items'/dynamic
 3 - Set circ rules to allow 1 hold per record on the relevant record
 4 - Place 3 holds on the record
 5 - Check one item in and confirm hold to set to waiting
 6 - Issue to the patron with the waiting hold
 7 - Get a notice that loan period is decreased
 8 - Don't confirm the checkout
 9 - Apply patch
10 - Restart all the things
11 - Repeat checkout, no decrease this time!

Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit 96a871035043c7ffd93c61e756ee1ff89e3da0f0)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit d59536e289692537289460a9225cc0c0bce80a57)

Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
C4/Circulation.pm
C4/Reserves.pm
t/db_dependent/DecreaseLoanHighHolds.t
t/db_dependent/Reserves/MultiplePerRecord.t