Bug 30194: (follow-up) Fix xt/api.t

The query object can have an arbitrary structure, and thus it doesn't
make sense to check for the additionalProperties presence. also, it is
not allowed by OpenAPIv2 :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>

diff --git a/xt/api.t b/xt/api.t
index 3d33a669bffba2d941f39b42a9e2f5e02e93069d..1dd206f498fa6eba80c08180558ce5d3da34c03e 100755 (executable)
--- a/xt/api.t
+++ b/xt/api.t
@@ -39,7 +39,8 @@ foreach my $route ( keys %{$paths} ) {
                 && $parameter->{schema}->{type} eq 'object' ) {
 
                 # it is an object type definition
-                if ( not exists $parameter->{schema}->{additionalProperties} ) {
+                if ( $parameter->{name} ne 'query' # our query parameter is under-specified
+                    and not exists $parameter->{schema}->{additionalProperties} ) {
                     push @missing_additionalProperties,
                       { type  => 'parameter',
                         route => $route,