]> git.koha-community.org Git - koha.git/log
koha.git
15 years agoBranch auto-selection in additem
Joe Atzberger [Wed, 8 Jul 2009 21:52:18 +0000 (16:52 -0500)]
Branch auto-selection in additem

Adding a new item should pre-select the library you are logged in at, where possible.
Use GetBranchesLoop.  This solves indy branches filtering, and sort order problems.
Set default off of ->{selected}, to establish pre-selected branch.
Fix flags check in onlymine sub, so superlibrarian + other flags still gets everything.
Removed defined(@array) check, since perl -wc warns it is deprecated.
Note new FIXME for botched date processing.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoLDAP overhaul
Joe Atzberger [Tue, 30 Jun 2009 14:14:50 +0000 (09:14 -0500)]
LDAP overhaul

Allow replicate and update to be zero.
Break out logic into separate subs.
Do only one bind attempt depending on setting, instead of
necessarily failing first before trying auth_by_bind.

POD added for active directory and to document permutations of
behavior given different conditions.  Fixed mistaken debug lines
that called "print STDERR printf ...", i.e. printed the line to output
and "1" to the error log.  Added principal_name feature for generating
bind user from Koha userid.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2539. Remove unintegrated "spsuggest" code from search scripts.
Joe Atzberger [Thu, 2 Jul 2009 03:47:35 +0000 (22:47 -0500)]
Bug 2539. Remove unintegrated "spsuggest" code from search scripts.

The intent of kohaspsuggest is very confused.  It wanted to simultaneously
log every search query, and get spelling suggestions from a totally different
database_host:db_user:db_password:database.  The implementation seems
never have really made it into 3.0, however, since the only trace of the
tables it wants to query are in misc/migration_tools/22_to_30/phrase_log.sql

The job misc/spellcheck_suggest/make_spellcheck_suggest.pl does not even
target the same remote DB as the syspref tells the search code to do.  Instead, it hits the
local DB and, not finding the tables that have no way of existing in a 3.0
install, it CREATES its own tables spontaneously, using MyISAM storage, no less.
This script should be drastically overhauled, or more likely just removed.

Other fixes:
Commented out unconditional warn!
Also reduced bizarre whitespace amounts in catalogue/search.pl and
fixed warning as recommended by perl -wc:
    Scalar value @newresults[0] better written as $newresults[0]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agonew icon included in OPAC details page rework
Galen Charlton [Wed, 15 Jul 2009 01:14:18 +0000 (21:14 -0400)]
new icon included in OPAC details page rework

Picked up icon from earlier version of Owen's patch
for bug 2713.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoCleanup opac-search.pl
Joe Atzberger [Thu, 2 Jul 2009 03:12:29 +0000 (22:12 -0500)]
Cleanup opac-search.pl

Use GetBranchesLoop.  Use elsif.  Use $format w/ a fallback "" value.

More to come.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #3267) show items.uri in opac and intranet
Nahuel ANGELINETTI [Thu, 25 Jun 2009 12:08:22 +0000 (14:08 +0200)]
(bug #3267) show items.uri in opac and intranet

This add a column in normal view, with a link to items.uri URL if it exists.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoSearch breadcrumb spacing
Joe Atzberger [Thu, 9 Jul 2009 18:30:36 +0000 (13:30 -0500)]
Search breadcrumb spacing

Also integrated both halves of the "searchdesc" conditional so they use the
same "No Result found!" message and <p> tags.
[LL 570]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoMinor Fixes for jQuery 1.3.2 Upgrade
John Beppu [Thu, 9 Jul 2009 01:09:00 +0000 (20:09 -0500)]
Minor Fixes for jQuery 1.3.2 Upgrade

I looked through all the relevant Javascript on this site
to find spots that would break in the upgrade from jQuery 1.2
to jQuery 1.3, and I fixed them.

Signed-off-by: John Beppu <john.beppu@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoMore changes to implement jQuery upgrade.
Owen Leonard [Thu, 9 Jul 2009 01:09:01 +0000 (20:09 -0500)]
More changes to implement jQuery upgrade.

- Upgrading jquery checkboxes plugin
- Correcting references to checkboxes plugin
- Upgrading jquery hotkeys plugin
- Upgrading syntax for calls to hotkeys plugin
- Removing jquery dimensions plugin (functionality rolled into jQuery)

Signed-off-by: John Beppu <john.beppu@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoUpgraded from jQuery 1.2.3 to 1.3.2
John Beppu [Wed, 8 Jul 2009 18:12:15 +0000 (13:12 -0500)]
Upgraded from jQuery 1.2.3 to 1.3.2

http://docs.jquery.com/Release:jQuery_1.3
http://www.learningjquery.com/2009/03/3-quick-steps-for-a-painless-upgrade-to-jquery-13

Signed-off-by: John Beppu <john.beppu@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFix for Bug 2713: Opac detail content overlaps when right column extends too far
Owen Leonard [Mon, 29 Jun 2009 20:00:09 +0000 (15:00 -0500)]
Fix for Bug 2713: Opac detail content overlaps when right column extends too far

Resubmitted. My proposed fix eliminates the OpacNav column on this page. It puts the "search for this title in..." links into a drop-down menu, and it moves the "similar items" display into a tab along with Holdings, Reviews, etc.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3384: Fixes invalid xhtml in advsearch.tmpl
Garry Collum [Thu, 2 Jul 2009 15:41:11 +0000 (11:41 -0400)]
Bug 3384: Fixes invalid xhtml in advsearch.tmpl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3390 Enabling ZIP compression in pdf generation to reduce file size
Chris Nighswonger [Sat, 4 Jul 2009 04:14:50 +0000 (00:14 -0400)]
Bug 3390 Enabling ZIP compression in pdf generation to reduce file size

Enabling compression gives a ~26% *reduction* over non-compressed Type 3 font embedding.
ie. 4.5 K/pg (compressed graphic) vs. 17.5 K/pg (uncompressed Type 3 font) vs 111 K/pg
(uncompressed graphic).

It also appears that most other applications that export in pdf use compression by
default. (OO Writer, etc.) So this approach appears justified. One could always add code
to allow the user to select embedding mode and compression.

Also correcting mode parameter value.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3390 Barcodes not displayed in Acro Reader >v7.0
Chris Nighswonger [Fri, 3 Jul 2009 16:59:26 +0000 (12:59 -0400)]
Bug 3390 Barcodes not displayed in Acro Reader >v7.0

Label pdfs containing barcodes generated by Koha do not display barcodes
properly in Adobe Reader >v7.0.

This does not appear to be a bug in Koha code nor in PDF::Reuse::Barcode code,
but rather in the backward compatibility of Adobe Reader.

This patch changes the barcode embedding method from a Type3
font to graphical embedding which appears to work around the issue.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoWhoops Ricardo was already in the list
Chris Cormack [Mon, 13 Jul 2009 04:43:57 +0000 (16:43 +1200)]
Whoops Ricardo was already in the list

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoUpdating history doc
Chris Cormack [Mon, 13 Jul 2009 04:41:17 +0000 (16:41 +1200)]
Updating history doc

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #3395) fix unimarc plugin 225$a
Nahuel ANGELINETTI [Mon, 6 Jul 2009 12:58:48 +0000 (14:58 +0200)]
(bug #3395) fix unimarc plugin 225$a

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2889: Cleaning up toggle variables in readingrec.pl and tmpl.
Garry Collum [Sat, 4 Jul 2009 20:48:17 +0000 (16:48 -0400)]
Bug 2889: Cleaning up toggle variables in readingrec.pl and tmpl.

Removed toggle variable from readingrec.pl and readingrec.tmpl.  Used __odd__ variable instead.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3392: Fixes highlighting in Patrons with no Checkouts report.
Garry Collum [Sun, 5 Jul 2009 00:18:15 +0000 (20:18 -0400)]
Bug 3392: Fixes highlighting in Patrons with no Checkouts report.

Fixed class definition and moved the definition from the <td> tags to the <tr> tags.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoCorrection to enable sending of update emails.
Owen Leonard [Mon, 6 Jul 2009 16:01:20 +0000 (11:01 -0500)]
Correction to enable sending of update emails.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoMoving the text of an error message from the script to the template where it can...
Owen Leonard [Mon, 6 Jul 2009 14:06:51 +0000 (09:06 -0500)]
Moving the text of an error message from the script to the template where it can be translated. Partial fix for bug 1153.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFix for Bug 2599 - Search limits not working for NoZebra
Ricardo Dias Marques [Fri, 3 Jul 2009 16:03:43 +0000 (16:03 +0000)]
Fix for Bug 2599 - Search limits not working for NoZebra

Adds the change suggested by Amer Denni to fix Bug 2599
in comment #7 at:

http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=2599

For UNIMARC installations, this patch only works after
updating the "NoZebraIndexes" system preference to
UNIMARC indexes (by default, NoZebraIndexes is being
wrongly set to MARC21 values in UNIMARC installations).

That has also been reported as a Bug, by me (see Bug 2178):

Bug 2178 - "NoZebraIndexes" system preference is being set
to MARC21 values in UNIMARC installations
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=2178

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug#: 3358 File 3 of 3 patch for reserve notes (show)
Darrell Ulm [Mon, 6 Jul 2009 20:57:22 +0000 (16:57 -0400)]
Bug#: 3358 File 3 of 3 patch for reserve notes (show)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug#: 3358 File 2 of 3 patch for reserve notes (show)
Darrell Ulm [Mon, 6 Jul 2009 20:57:21 +0000 (16:57 -0400)]
Bug#: 3358 File 2 of 3 patch for reserve notes (show)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug#: 3358 File 1 of 3 patch for reserve notes (show)
Darrell Ulm [Mon, 6 Jul 2009 20:57:20 +0000 (16:57 -0400)]
Bug#: 3358 File 1 of 3 patch for reserve notes (show)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3355 followup - fix XHTML errors
Galen Charlton [Mon, 13 Jul 2009 03:06:35 +0000 (23:06 -0400)]
bug 3355 followup - fix XHTML errors

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #3355) add pagination in bib search for subscriptions
Nahuel ANGELINETTI [Wed, 24 Jun 2009 09:00:48 +0000 (11:00 +0200)]
(bug #3355) add pagination in bib search for subscriptions

This add the support of pagination, delete a javascript call, and use now a get method(why post was used?).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #3284) fix superlibrarian check
Nahuel ANGELINETTI [Fri, 26 Jun 2009 09:25:01 +0000 (11:25 +0200)]
(bug #3284) fix superlibrarian check

This fix the superlibrarian check in the previous fix.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #3284) fix borrower deletion in independantbranches mode
Nahuel ANGELINETTI [Thu, 25 Jun 2009 10:57:35 +0000 (12:57 +0200)]
(bug #3284) fix borrower deletion in independantbranches mode

This patch fix the checks deleting a borrower in independantbranches mode.
Now, we check the user and the librarian are from the same branch, else we deny the deletion(and disable the link to delete).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #3363) do not reload parent if you add a biblio in shelf
Nahuel ANGELINETTI [Thu, 25 Jun 2009 10:44:11 +0000 (12:44 +0200)]
(bug #3363) do not reload parent if you add a biblio in shelf

this patch make the script not reloading the parent if the user add a biblio in a already existing shelf(useless).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3229: Fixes sort-by feature for jquery tablesorter in lists.
Garry Collum [Wed, 24 Jun 2009 01:42:05 +0000 (21:42 -0400)]
Bug 3229: Fixes sort-by feature for jquery tablesorter in lists.

This patch adds some variables for the sortfield that are passed through the URL so that the sort-by feature works when the jquery tablesorter is used for a list of titles in opac-shelves.tmpl.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3347: Follow-up patch. Added logic for non-loggedin user.
Garry Collum [Sat, 20 Jun 2009 21:00:53 +0000 (17:00 -0400)]
Bug 3347: Follow-up patch. Added logic for non-loggedin user.

Adds a login message, instead of a "New List" link, to the public list table, if a non-logged in user views the table.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3347: Inconsistencies with public and private list tables in opac-shelves.tmpl.
Garry Collum [Sat, 20 Jun 2009 02:42:46 +0000 (22:42 -0400)]
Bug 3347: Inconsistencies with public and private list tables in opac-shelves.tmpl.

This patch fixes inconsistencies with the public and private list tables in opac-shelves.tmpl.  It adds a "new list" link to the public list view, and it adds a "sort by" column.

This patch also removes the toggle variables from the tables in opac-shelves.tmpl and Page.pm, and uses the template __odd__ variable for table highlighting if javascript is turned off.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3346: Fixes invalid XHTML in opac-shelves.tmpl
Garry Collum [Sat, 20 Jun 2009 00:58:15 +0000 (20:58 -0400)]
Bug 3346: Fixes invalid XHTML in opac-shelves.tmpl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoRemoving hard-coded $ symbols from the template, addressing Bug 2547
Owen Leonard [Mon, 29 Jun 2009 16:17:49 +0000 (11:17 -0500)]
Removing hard-coded $ symbols from the template, addressing Bug 2547

Pending a system for displaying the correct currency symbol based on the system's default currency all dollar-specific symbols should be removed in favor of no symbol.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoTweaking CSS on z39.50 popup to improve readability (Bug 3269)
Owen Leonard [Mon, 29 Jun 2009 18:23:22 +0000 (13:23 -0500)]
Tweaking CSS on z39.50 popup to improve readability (Bug 3269)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoModifying the text of the error message for clarity and accuracy.
Owen Leonard [Mon, 29 Jun 2009 15:08:30 +0000 (10:08 -0500)]
Modifying the text of the error message for clarity and accuracy.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoCorrecting validation errors.
Owen Leonard [Thu, 25 Jun 2009 15:44:46 +0000 (10:44 -0500)]
Correcting validation errors.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3360: Fix for unclosed <ol> element in export.tmpl
Garry Collum [Thu, 25 Jun 2009 00:23:39 +0000 (20:23 -0400)]
Bug 3360: Fix for unclosed <ol> element in export.tmpl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3362: Fixes invalid xhtml in stage-marc-import.tmpl
Garry Collum [Thu, 25 Jun 2009 02:23:46 +0000 (22:23 -0400)]
Bug 3362: Fixes invalid xhtml in stage-marc-import.tmpl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoMisplaced </tbody> breaks table sorting. Fixes Bug 3365.
Owen Leonard [Mon, 29 Jun 2009 13:43:04 +0000 (08:43 -0500)]
Misplaced </tbody> breaks table sorting. Fixes Bug 3365.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoReformatting interface for Notice Triggers (Bug 3366)
Owen Leonard [Thu, 25 Jun 2009 16:45:02 +0000 (11:45 -0500)]
Reformatting interface for Notice Triggers (Bug 3366)

Breaking up the table of options into three separate ones for first, second, and third notices, each in its own tab.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoPutting text form field first ensures field will correctly be given focus.
Owen Leonard [Thu, 25 Jun 2009 14:02:26 +0000 (09:02 -0500)]
Putting text form field first ensures field will correctly be given focus.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #3364) add itemnotes in itemslost report
Nahuel ANGELINETTI [Thu, 25 Jun 2009 13:19:37 +0000 (15:19 +0200)]
(bug #3364) add itemnotes in itemslost report

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #3368) index 464$t in unimarc
Nahuel ANGELINETTI [Fri, 26 Jun 2009 07:13:50 +0000 (09:13 +0200)]
(bug #3368) index 464$t in unimarc

this patch add 464$t part of Title index

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #3369) add 995$* unimarc fields in "item" index
Nahuel ANGELINETTI [Fri, 26 Jun 2009 11:24:14 +0000 (13:24 +0200)]
(bug #3369) add 995$* unimarc fields in "item" index

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoSpelling correction per convention: cataloguing -> cataloging (Bug 3277)
Owen Leonard [Sat, 27 Jun 2009 15:43:17 +0000 (10:43 -0500)]
Spelling correction per convention: cataloguing -> cataloging (Bug 3277)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2889: Cleaned up toggle variable in opac-readingrecord.tmpl. Disregard previous...
Garry Collum [Fri, 26 Jun 2009 00:27:56 +0000 (20:27 -0400)]
Bug 2889: Cleaned up toggle variable in opac-readingrecord.tmpl. Disregard previous patch.

Cleaned up toggle variable in opac-readingrecord.pl and tmpl.  Used __odd__ variable instead.

Missed </TMPL_UNLESS> in previous patch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2889: Removed toggle variable from z3950_search.pl.
Garry Collum [Fri, 26 Jun 2009 00:35:14 +0000 (20:35 -0400)]
Bug 2889: Removed toggle variable from z3950_search.pl.

Removed unused toggle variable from z3959_search.pl.  Added __odd__ variable to table in z3950_search.tmpl for non-javascript users.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAnother fix for Bug 3119 (Add date due to circ history)
Owen Leonard [Thu, 25 Jun 2009 13:28:42 +0000 (08:28 -0500)]
Another fix for Bug 3119 (Add date due to circ history)

Moving links (non-table data) out of table to correct persistent table border display issue.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoModified fines.pl to not throw warning if --out not specified
J. David Bavousett [Thu, 25 Jun 2009 14:43:39 +0000 (10:43 -0400)]
Modified fines.pl to not throw warning if --out not specified

It appears, in Ryan's patch, that he wants to throw a warning to the log if
the directory specified in --out is not present.  (Further messages will
be given when the open-or-die occurs a few lines later.)  However, it was
throwing the warning if --out was not specified at all, which is
undesirable.  This patch modifies that bit to check for the presence of
whatever directory is going to be used, either --out, ENV{TMPDIR}, or /tmp.
As before, if the write to the directory fails for any reason--including
its' non-existence--that is handled later, but this message will help
inform the troubleshooter.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 3359 changed "registration branch" to "library" on moremember.tmpl for the sake...
Liz Rea [Thu, 25 Jun 2009 14:46:31 +0000 (09:46 -0500)]
bug 3359 changed "registration branch" to "library" on moremember.tmpl for the sake of consistency.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3301 - Speed up rebuild_zebra script
Frédéric Demians [Sun, 14 Jun 2009 05:17:40 +0000 (07:17 +0200)]
Bug 3301 - Speed up rebuild_zebra script

With this patch, rebuild_zebra can re-index a whole Koha DB
quickly:

  rebuild_zebra -r -b -nosanitize

Biblio (authority) records are dump directly in a file
from marcxml field without beeing transformed into
MARC::Record object and corrected.

DOCUMENTATION:

rebuild_zebra.pl new paramater:

-nosanitize  export biblio/authority records directly from DB marcxml
             field without sanitizing records. It speed up
             dump process but could fail if DB contains badly
             encoded records. Works now only with -x and -b

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoReturns reworking to handle empty GetItemIssue
Joe Atzberger [Thu, 18 Jun 2009 16:31:33 +0000 (11:31 -0500)]
Returns reworking to handle empty GetItemIssue

Code cannot rely on issueinformation being populated.

Note there is room for better efficiency to have AddReturn also provide the
itemnumber (where existing) so that GetItemnumberFromBarcode is not called
at both levels.  Unfortunately there is discrepancy between this idea (for
efficiency) and the stated purpose of the $iteminformation object returned,
since $iteminformation is specifically the info from the issues table and
MUST be empty when the item was not in fact issued.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agocheckoverdues should not require $dbh
Joe Atzberger [Sat, 20 Jun 2009 00:32:42 +0000 (19:32 -0500)]
checkoverdues should not require $dbh

Passing $dbh around is an ancient style that doesn't know
to use C4::Context.  C4::Context->dbh is efficient, especially
for modules that already use Context, including almost all C4.

I also internalized $today into the SQL using NOW() in the query
and removed sth->finish.  Even though I dislike the return style
that gives the count, then the array, I left it becuase I don't
have time to fix/test all the callers.  However, I did convert
it so it doesn't require a $count variable and its own loop.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoReturn amount for CREDITS, POD rework.
Joe Atzberger [Sat, 20 Jun 2009 00:32:44 +0000 (19:32 -0500)]
Return amount for CREDITS, POD rework.

The main change here is to get an {amount} field for CREDITS,
not just CHARGES.  I also use a fallback to default value (5)
in case noissuescharge has been deleted or set to 0.

POD is reworked to keep the salient chunks
about patronflags in the correct section and format them for
easier reference.  Deprecated display layer code.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoCleanup Members.pm - minor
Joe Atzberger [Sat, 20 Jun 2009 00:32:45 +0000 (19:32 -0500)]
Cleanup Members.pm - minor

MoveMemberToDeleted is problematic.  It has a bad name, since it
only copies, not moves.  Also the POD for it referenced a totally
different function name and was largely useless.  Sanity checks inserted.

A couple sth->finish removed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoRemove unused variable and add FIXME.
Joe Atzberger [Sat, 20 Jun 2009 00:32:43 +0000 (19:32 -0500)]
Remove unused variable and add FIXME.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdding installation documentation for Ubuntu
Chris Nighswonger [Tue, 23 Jun 2009 17:18:04 +0000 (13:18 -0400)]
Adding installation documentation for Ubuntu

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofixed table row highlighting CSS class
Galen Charlton [Wed, 24 Jun 2009 14:09:27 +0000 (09:09 -0500)]
fixed table row highlighting CSS class

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoEnable warnings in addbooks.pl Fix code generating undef and mis-matched op warnings...
Colin Campbell [Tue, 23 Jun 2009 08:14:31 +0000 (09:14 +0100)]
Enable warnings in addbooks.pl Fix code generating undef and mis-matched op warnings Remove toggle variable

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFunctional SIP run and shutdown scripts. Update example SIPconfig.xml
Joe Atzberger (siptest [Sat, 20 Jun 2009 00:32:41 +0000 (19:32 -0500)]
Functional SIP run and shutdown scripts. Update example SIPconfig.xml

Note the shutdown script is quick and dirty, and probably
platform (debian) specific.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug # 2368 Change holds to pull default date range
Jane Wagner [Fri, 19 Jun 2009 13:10:20 +0000 (09:10 -0400)]
Bug # 2368 Change holds to pull default date range

Delivered range was 10 years ago to yesterday; changed default
to be two days ago to today.  Also removed notes field from report
output; 5xx fields can be quite large and including them in the
display resulted in a very lengthy printout for staff.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3350 - fail on queued emails w/ no address
Joe Atzberger [Mon, 22 Jun 2009 19:40:56 +0000 (14:40 -0500)]
Bug 3350 - fail on queued emails w/ no address

If a patron has no email address, we need to avoid stockpiling all
their messages indefinitely.  Otherwise they get mailbombed when
their email IS added.

Note that overdues should not be affected, since the overdues job
checks whether the patron email exists before sending the message
(falling back to the admin).  The other messaging features are the
targets affected by this patch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3351 - Limit Serials Search for Biblio to an item type
Frédéric Demians [Tue, 23 Jun 2009 12:01:14 +0000 (14:01 +0200)]
Bug 3351 - Limit Serials Search for Biblio to an item type

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdding links to guided reports wizard, dictionary, create from sql to reports home...
Liz Rea [Tue, 23 Jun 2009 18:11:24 +0000 (13:11 -0500)]
Adding links to guided reports wizard, dictionary, create from sql to reports home page.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug Fixing : 3334
Henri-Damien LAURENT [Fri, 19 Jun 2009 11:23:33 +0000 (13:23 +0200)]
Bug Fixing : 3334

MANIFEST.SKIP with grouping orig back and old
had a problem with hold-transfer-slip.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoCorrect POD and misleading variable names from copy/paste laziness
Joe Atzberger [Thu, 18 Jun 2009 16:31:32 +0000 (11:31 -0500)]
Correct POD and misleading variable names from copy/paste laziness

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #3339) fix rollover showed value
Nahuel ANGELINETTI [Thu, 18 Jun 2009 13:43:29 +0000 (15:43 +0200)]
(bug #3339) fix rollover showed value

This patch just print the value of "whenmorethan1", that was missed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3338: Fix for missing closing brackets in authorities/detail.tmpl
Garry Collum [Thu, 18 Jun 2009 09:18:26 +0000 (05:18 -0400)]
Bug 3338: Fix for missing closing brackets in authorities/detail.tmpl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2893: extend conditions handled by AllowNotForLoanOverride
Galen Charlton [Wed, 17 Jun 2009 13:00:57 +0000 (08:00 -0500)]
bug 2893: extend conditions handled by AllowNotForLoanOverride

Prior to this patch, turning AllowNotForLoanOverride on
allowed the circ operator to permit the loan of an
item who's individual not-for-loan flag was set, but did
not allow the loan of an item whose item type's not-for-loan
flag was set.  This patch extends the definition of the
system preference so that both cases are covered.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agouse Memoize to cache results of GetAuthorisedValues
Galen Charlton [Wed, 17 Jun 2009 21:27:34 +0000 (16:27 -0500)]
use Memoize to cache results of GetAuthorisedValues

Thanks to Frédéric Demians for the original impetus
to improve this function and for doing profiling.

Note that Memoize is a core module since at least 5.8.0.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdd MARC21 Fast-add Framework.
Ryan Higgins [Mon, 15 Jun 2009 22:20:29 +0000 (17:20 -0500)]
Add MARC21 Fast-add Framework.

Development is in progress for brief records
in Koha; until that's done, this framework can
be used to add a minimal record.
Created by debra.denault@liblime.com

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoRevision to my earlier patch for displaying the user name on checked-out items
Jane Wagner [Tue, 16 Jun 2009 16:28:06 +0000 (12:28 -0400)]
Revision to my earlier patch for displaying the user name on checked-out items

My earlier patch (using the new syspref OPACShowCheckoutName mistakenly
displayed the Koha borrower number instead of the patron barcode number
in the OPAC display; this revises the script/template to use barcode.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoExpand interactive SIP tests.
Joe Atzberger (siptest [Tue, 16 Jun 2009 17:11:35 +0000 (12:11 -0500)]
Expand interactive SIP tests.

Also tweak interactive item dump to suppress huge fields (marc, marcxml).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3317: Author displaying inconsistently or not at all. Revision to previous patch.
Garry Collum [Wed, 17 Jun 2009 00:37:51 +0000 (20:37 -0400)]
Bug 3317: Author displaying inconsistently or not at all. Revision to previous patch.

Revision to previous patch for bug 3317.  Removes the EXPR command from opac-basket.tmpl, which was polluting the apache logs.

NTS: Don't use EXPR.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #2829) allow isbn13 in sql requests
Nahuel ANGELINETTI [Wed, 17 Jun 2009 13:46:45 +0000 (15:46 +0200)]
(bug #2829) allow isbn13 in sql requests

this patch add the support of the plugin to search for isbn13.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #2829) mistake un isbn field
Nahuel ANGELINETTI [Wed, 17 Jun 2009 12:39:02 +0000 (14:39 +0200)]
(bug #2829) mistake un isbn field

I compare the bad part of the isbn in my first version, now fixed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3317: Author displaying inconsistently or not at all in Cart.
Garry Collum [Sun, 14 Jun 2009 21:43:37 +0000 (17:43 -0400)]
Bug 3317: Author displaying inconsistently or not at all in Cart.

This patch fixes the author and added author fields for the 'More Details' view of opac-basket.tmpl.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3325: Fixes XHTML errors in opac-basket.tmpl.
Garry Collum [Sat, 13 Jun 2009 02:44:27 +0000 (22:44 -0400)]
Bug 3325: Fixes XHTML errors in opac-basket.tmpl.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 3228: Fix for Type: label in XSLT displays.
Garry Collum [Sat, 13 Jun 2009 14:51:45 +0000 (10:51 -0400)]
Bug 3228: Fix for Type: label in XSLT displays.

Empty nodes must be generated in the XML for MARC21slim2OPACResults - typeOf008 and MARC21slim2OPACResults - materialTypeCode when the fields in the Marc record do not exist.  This patch fixes the "Type: " label.  More testing needs to be done to see if any other labels appear in the Opac if the data is not defined in the MARC record.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdd a Debian Lenny package
Frédéric Demians [Sun, 14 Jun 2009 05:17:42 +0000 (07:17 +0200)]
Add a Debian Lenny package

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2889: Removed toggle variable from member.pl and .tmpl
Garry Collum [Sun, 14 Jun 2009 08:36:16 +0000 (04:36 -0400)]
Bug 2889: Removed toggle variable from member.pl and .tmpl

Removed toggle variable from member.pl and member.tmpl.  Replaced with template variable __odd__.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdd Getopt::Long to fines.pl, and option to specify log output directory.
Ryan Higgins [Mon, 15 Jun 2009 03:20:42 +0000 (22:20 -0500)]
Add Getopt::Long to fines.pl, and option to specify log output directory.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago(bug #3329) Dependency missing in inventory.pl
Nahuel ANGELINETTI [Mon, 15 Jun 2009 10:19:37 +0000 (12:19 +0200)]
(bug #3329) Dependency missing in inventory.pl

The called function AddReturn is in C4::Circulation which is not loaded, this patch do it.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoUse strftime to format sessionlog times
MJ Ray [Mon, 15 Jun 2009 12:51:43 +0000 (13:51 +0100)]
Use strftime to format sessionlog times

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFix an unstranslatable string in JavaScript
Frédéric Demians [Mon, 15 Jun 2009 15:32:51 +0000 (17:32 +0200)]
Fix an unstranslatable string in JavaScript

For an explanation, see:

http://wiki.koha.org/doku.php?id=en:development:codingguidelines#translatable_text

This bug blocks entirely serials module. It isn't possible
to create/edit a subscription. Brocken JavaScript prevents
Search for a vendor and Search for Biblio dialog box
to pop-up.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoUpdate references to batchRebuildBiblioTables
Joe Atzberger [Mon, 15 Jun 2009 16:32:19 +0000 (11:32 -0500)]
Update references to batchRebuildBiblioTables

Also fixed escaping of literal "$" characters in usage.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFix bug 3330 - Report notes modification
Frédéric Demians [Mon, 15 Jun 2009 17:18:51 +0000 (19:18 +0200)]
Fix bug 3330 - Report notes modification

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoCleanup stopwords.pl and .tmpl
Joe Atzberger [Fri, 12 Jun 2009 22:33:02 +0000 (17:33 -0500)]
Cleanup stopwords.pl and .tmpl

Remove "toggle" code and useless javascript.
Rework "SimpleSearch" to use just one argument.
Remove unnecessary dependencies.
Remove incorrectly pasted comments.
Remove queries that didn't do anything.
Enable warnings.  Use one $dbh.  Remove $sth->finish calls.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoCleanup - moremember.pl and .tmpl
Joe Atzberger [Fri, 12 Jun 2009 22:33:03 +0000 (17:33 -0500)]
Cleanup - moremember.pl and .tmpl

Removed last 3 EXPR statements.  Removed toggle code.
Fixed jquery for warning on image deletion.
Fixed permission check for image upload to be granular.
Lots of formatting/whitespace cleanup.
Removed useless form and unused template vars.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdding a notes column, fixing a typo in TMPL_VAR statement that caused notes not...
Liz Rea [Fri, 12 Jun 2009 13:02:59 +0000 (08:02 -0500)]
Adding a notes column, fixing a typo in TMPL_VAR statement that caused notes not to display.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2889: Removed toggle variable from auth_tag_structure.pl and auth_subfields_struc...
Garry Collum [Thu, 11 Jun 2009 19:15:38 +0000 (15:15 -0400)]
Bug 2889: Removed toggle variable from auth_tag_structure.pl and auth_subfields_structure.pl

Removed toggle variable from auth_tag_structure.pl and .tmpl.  Used template __odd__ in auth_tag_structure.tmpl.

Removed toggle variable from auth_subfields_structure.pl and .tmpl. Use __odd__. Removed a type in the highlight class definition. Fixed a minor xhtml error.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofollowup - restore correct conditional
Galen Charlton [Fri, 12 Jun 2009 15:31:10 +0000 (10:31 -0500)]
followup - restore correct conditional

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofixed broken link in patron label search
Galen Charlton [Fri, 12 Jun 2009 15:08:40 +0000 (10:08 -0500)]
fixed broken link in patron label search

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoMissed Chris Nighswonger from the developer list, fixed
Chris Cormack [Thu, 11 Jun 2009 18:53:31 +0000 (06:53 +1200)]
Missed Chris Nighswonger from the developer list, fixed

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2889: Removed unused toggle variables from booksellers.pl. Added table highlighti...
Garry Collum [Thu, 11 Jun 2009 21:38:59 +0000 (17:38 -0400)]
Bug 2889: Removed unused toggle variables from booksellers.pl. Added table highlighting to booksellers.tmpl.

Removed unused toggle and line(even) variables from booksellers.pl.  Added highlighting to the two display tables in booksellers.tmpl.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoCleanup: biblio_framework and marctagstructure
Joe Atzberger [Wed, 10 Jun 2009 21:53:28 +0000 (16:53 -0500)]
Cleanup: biblio_framework and marctagstructure

Removed unused javascript.  Enabled warnings.  Use common $dbh.
Removed sth->finish calls.  Removed toggle code.  Added row highlight where
none had been implemented.  Repaired validation error w/ mislocated input tag.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoCleanup classsources.pl and .tmpl
Joe Atzberger [Wed, 10 Jun 2009 21:53:27 +0000 (16:53 -0500)]
Cleanup classsources.pl and .tmpl

Relatively minor cleaning.
Remove unused javascript.  Add row highlighting to both tables.  Remove conditionals where the
behavior is the same for both possibilities.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2889: Removed toggle from marc_subfields_structure.pl and .tmpl
Garry Collum [Thu, 11 Jun 2009 20:44:30 +0000 (16:44 -0400)]
Bug 2889: Removed toggle from marc_subfields_structure.pl and .tmpl

Removed toggle variable from marc_subfields_structure.pl and marc_subfields_structure.tmpl.  Used template __odd__ variable instead.

Corrected a typo in the highlight class definition in .tmpl.

Corrected a readability issue with the description when deleting a subfield in .tmpl.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>