]> git.koha-community.org Git - koha.git/log
koha.git
15 years ago[bug #2750] Cannot return to another branch if the independantbranch option is set...
Henri-Damien LAURENT [Mon, 24 Nov 2008 08:43:32 +0000 (09:43 +0100)]
[bug #2750] Cannot return to another branch if the independantbranch option is set as ON

The code was modified to change the holding branch ONLY if the return to
the right branch is done. If you set IndependantBranch to on, you must
return the document to the HomeBranch.
And verify the return is done before show the message that allow to
transfert the document to another branch.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoAllow renewal limits to be overridden
Henri-Damien LAURENT [Mon, 24 Nov 2008 05:29:58 +0000 (06:29 +0100)]
Allow renewal limits to be overridden

Originally by Jesse Weaver <jesse.weaver@liblime.com>

This patch creates a new system preference, AllowRenewalLimitOverride,
that, if YES, allows the renewal limit to be manually overridden. It
updates C4::Circulation and reserve/renewscript.pl to obey this.

Adapted for 3.0 : Henri-Damien LAURENT
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBugs 2541 and 2587 - AddIssue must return date object as intended.
Joe Atzberger (siptest [Thu, 11 Sep 2008 03:30:04 +0000 (22:30 -0500)]
Bugs 2541 and 2587 - AddIssue must return date object as intended.

SIP actually relied on the AddIssue return that was not reliable.
AddRenew also updated to return C4::Dates object for datedue.

Please note, any running SIPServer will have to be restarted
*immediately* after applying this patch, because although Koha
C4 behaves as normal, the SIP server runs as a Net::Server with
components cached.  Changes will not be applied until SIPServer
restarts, and so checkout actions may fail until then.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years ago[REPLACE previous] Removing map calls in void context
Henri-Damien LAURENT [Wed, 19 Nov 2008 15:03:50 +0000 (16:03 +0100)]
[REPLACE previous] Removing map calls in void context

Thanks Joe.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoUpdate MARC to add 099$c and 099$d fields, with :
Henri-Damien LAURENT [Fri, 21 Nov 2008 21:37:04 +0000 (22:37 +0100)]
Update MARC to add 099$c and 099$d fields, with :

This allow the acquisition date sorting in UNIMARC.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoUpdating default UNIMARC framework
Henri-Damien LAURENT [Sat, 22 Nov 2008 06:17:44 +0000 (07:17 +0100)]
Updating default UNIMARC framework

The previous one was out of date and contained some errors.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 2801 and other cleanup.
Joe Atzberger [Tue, 18 Nov 2008 16:33:54 +0000 (10:33 -0600)]
Bug 2801 and other cleanup.

In addition to documented bug:
~ SearchString took an unused argument,
~ refactored repeated code into column_picks(),
~ fixed display during delete_confirm, including "name",
~ removed unused C4::Dates dependency.

Resend: typo fixed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agobug 2531 followup
Galen Charlton [Fri, 21 Nov 2008 00:12:42 +0000 (18:12 -0600)]
bug 2531 followup

* & -> &amp; in URL for XHTML validation
* (unrelated to prior patch) remove broken link to
  button-bg.png for confirm button

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug #2531 Cannot delete private shelf
Allen Reinmeyer [Mon, 17 Nov 2008 21:10:27 +0000 (15:10 -0600)]
Bug #2531 Cannot delete private shelf

Added logic to create a list of private lists to check on deletion.  Multiple pages have the ability to delete lists, both private and public.  Default option of retrieving a user's lists is retrieving the public ones.  Now private lists of the owner are retrieved as well and checked upon deletion request.  This allows any method of deletion to delete the correct list without examining the myriad of options currently used to indicate display of privateshelves and expect all pages to know whether a shelf number comes from a private or public list.  Since deletion occurs based on shelf number and the virtualshelves table has a primary key on shelf number, this will not cause unwanted deletion of shelves.

UPDATE:  added logic for conditional creation of shelves.  Also note change in staff side as deletions worked except for viewing a populated shelf, then deleting.  The confirm message showed, but the display was of public shelves, not private.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 2365: Serials prediction errors: Roll-overs occur with wrong issue in some cases.
Ryan Higgins [Wed, 19 Nov 2008 15:55:38 +0000 (09:55 -0600)]
Bug 2365: Serials prediction errors: Roll-overs occur with wrong issue in some cases.

See bugzilla for details.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoproblem saving authority with ? and other special characters [resend]
Henri-Damien LAURENT [Wed, 19 Nov 2008 14:36:18 +0000 (15:36 +0100)]
problem saving authority with ? and other special characters [resend]

Filtering those signs in order not to have them interpreted.
Removing some warns

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoImproving UNIMARC(A) compliance
Henri-Damien LAURENT [Wed, 19 Nov 2008 10:59:29 +0000 (11:59 +0100)]
Improving UNIMARC(A) compliance

Adding some fields to index.
Adding also some indexes in order to be able to query specific fields.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoUse biblioitems.itemtype as a default for items.itype
Michael Hafen [Fri, 12 Sep 2008 19:16:58 +0000 (13:16 -0600)]
Use biblioitems.itemtype as a default for items.itype

This correct the html select default in additem.pl, and enforces use of
biblioitems.itemtype as the default in Items::AddItem.  The code in
Items is to catch items added through MARC record staging.

Thanks to Joe Atzberger for suggestion.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agofix for bug 2447: yuipath variable not getting passed to help pages
Jesse Weaver [Fri, 22 Aug 2008 15:54:30 +0000 (10:54 -0500)]
fix for bug 2447: yuipath variable not getting passed to help pages

This updates help.pl to pass the yuipath variable correctly. It also adds some script references to help-top.inc to avoid other js errors.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoGet back boolean button on OPAC Advanced Search page
Frédéric DEMIANS [Wed, 1 Oct 2008 16:09:16 +0000 (18:09 +0200)]
Get back boolean button on OPAC Advanced Search page

With this patch, on OPAC Advanced Search page, when More Options is
selected, a boolean combo box appears in front of fields combo box.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agobug fix 2765
Henri-Damien LAURENT [Mon, 17 Nov 2008 09:56:49 +0000 (10:56 +0100)]
bug fix 2765

Changing isbn data from 14 to 30 in order to manage friendlier,
isbn with - inside, and multiple isbns.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 2790 no UNIMARC search on avail items [1/2]
Henri-Damien LAURENT [Mon, 17 Nov 2008 05:46:55 +0000 (06:46 +0100)]
Bug 2790 no UNIMARC search on avail items [1/2]

Changing record.abs file to add the management of acquisition date,
modification date and lost

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug Fix : 2494
Henri-Damien LAURENT [Thu, 30 Oct 2008 16:14:18 +0000 (17:14 +0100)]
Bug Fix : 2494

Adds some rewriting
bug fix for merging
AddAuthority had some problem with updating existing data.
ModAuthority adds a new Syspref called MergeAuthoritiesOnUpdate which is used to launch or disable biblios update when updating an authority

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoMerging authorities caused an encoding problem in biblios
Henri-Damien LAURENT [Thu, 30 Oct 2008 16:11:39 +0000 (17:11 +0100)]
Merging authorities caused an encoding problem in biblios

MARC::File::USMARC::decode is not aware of encoding as MARC::File::XML is
So it caused a problem when decoding information and updating biblios.
Now uses MARC::File::XML
Encoding is OK

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug Fixing : export would export no biblios when
Henri-Damien LAURENT [Tue, 28 Oct 2008 12:11:16 +0000 (13:11 +0100)]
Bug Fixing : export would export no biblios when

IndependantBranches set and user is kohaadmin
I think we can escape defaulting to the userenv Branch with
restricting the list to the user branch

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug Fix : 2686
Henri-Damien LAURENT [Thu, 16 Oct 2008 17:08:01 +0000 (19:08 +0200)]
Bug Fix : 2686

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoAdding some Error proof on GetAuthority
Henri-Damien LAURENT [Wed, 15 Oct 2008 19:36:44 +0000 (21:36 +0200)]
Adding some Error proof on GetAuthority

return undef if there is a problem

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agomerge_authority : Bug fixing
Henri-Damien LAURENT [Wed, 15 Oct 2008 19:36:06 +0000 (21:36 +0200)]
merge_authority : Bug fixing

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug Fix : Adding Some error proofs to HaveSubscriptionExpired
Henri-Damien LAURENT [Mon, 6 Oct 2008 14:53:40 +0000 (16:53 +0200)]
Bug Fix : Adding Some error proofs to HaveSubscriptionExpired

Date::Calc::CalcDays was throwing error 500 when one serial had an undefined date.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug Fix : When Patron had overdues, it was possible to checkout
Henri-Damien LAURENT [Wed, 3 Sep 2008 16:39:36 +0000 (18:39 +0200)]
Bug Fix : When Patron had overdues, it was possible to checkout

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoUsing Warns would cause problems with NoZebra
Henri-Damien LAURENT [Wed, 13 Aug 2008 06:39:04 +0000 (08:39 +0200)]
Using Warns would cause problems with NoZebra

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoAdding some fixing for NoZebra
Henri-Damien LAURENT [Tue, 12 Aug 2008 07:28:16 +0000 (09:28 +0200)]
Adding some fixing for NoZebra

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoMinor Feature : username when cataloguing
Henri-Damien LAURENT [Fri, 1 Aug 2008 08:18:10 +0000 (10:18 +0200)]
Minor Feature : username when cataloguing

biblios can now be added librarian name automatically when cataloguing.
add "user" in the Default value of the biblio

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug Fixing : searching on mainmainentry was disabled
Henri-Damien LAURENT [Wed, 4 Jun 2008 14:48:34 +0000 (16:48 +0200)]
Bug Fixing : searching on mainmainentry was disabled

Adding Heading-Main as new index code in order to search only on Heading-main when $a selected.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoRestoring startsby search on authorities.
Henri-Damien LAURENT [Wed, 4 Jun 2008 07:37:38 +0000 (09:37 +0200)]
Restoring startsby search on authorities.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agocreating update database for 3.0.1
Henri-Damien LAURENT [Mon, 24 Nov 2008 16:44:58 +0000 (17:44 +0100)]
creating update database for 3.0.1

- adds 2 new sys prefs AllowRenewalOverride and MergeAuthoritiesOnupdate AllowRenewallOverride
MergeAuthoritiesOnUpdate
- set null issues.issuedate to lastreneweddate
- Adding some changes in Database for bugfixes only UNIMARC

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoUsing Warns would cause problems with NoZebra
Henri-Damien LAURENT [Wed, 13 Aug 2008 06:39:04 +0000 (08:39 +0200)]
Using Warns would cause problems with NoZebra

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug Fix : 2494
Henri-Damien LAURENT [Thu, 30 Oct 2008 16:14:18 +0000 (17:14 +0100)]
Bug Fix : 2494

Adds some rewriting
bug fix for merging
AddAuthority had some problem with updating existing data.
ModAuthority adds a new Syspref called MergeAuthoritiesOnUpdate which is used to launch or disable biblios update when updating an authority

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agobug 2802 followup: remove another reference to "branches"
Galen Charlton [Tue, 18 Nov 2008 22:50:25 +0000 (16:50 -0600)]
bug 2802 followup: remove another reference to "branches"

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug fix : 2805
Henri-Damien LAURENT [Tue, 18 Nov 2008 15:18:15 +0000 (16:18 +0100)]
bug fix : 2805

deleting die on lack of user/password in config file.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoLanguage corrections: branch -> library. Changing "Libraries, branches, and groups...
Owen Leonard [Tue, 18 Nov 2008 16:01:27 +0000 (10:01 -0600)]
Language corrections: branch -> library. Changing "Libraries, branches, and groups" to "Libraries and groups." Fixes Bug 2802.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoadd isbn to cataloging search results
Michael Hafen [Tue, 18 Nov 2008 22:17:16 +0000 (15:17 -0700)]
add isbn to cataloging search results

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoDo not show the language chooser
Nahuel Angelinetti [Mon, 17 Nov 2008 16:18:18 +0000 (17:18 +0100)]
Do not show the language chooser

This patch change the footer of authority search results popup to use the popup footer, so do not show the language chooser.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agomoved Test_CSV_Various.t to xt/author
Galen Charlton [Mon, 17 Nov 2008 16:18:38 +0000 (10:18 -0600)]
moved Test_CSV_Various.t to xt/author

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoResults of CSV module analysis, testing various CSV modules and configs.
Joe Atzberger [Fri, 7 Nov 2008 21:49:59 +0000 (15:49 -0600)]
Results of CSV module analysis, testing various CSV modules and configs.

The upshot is that despite appearances, whe should NEVER use Text::CSV::Unicode
or any CSV module in non-binary mode.  Text::CSV works in binary mode
by using Text::CSV_XS, so the behavior is the same for both (in binary).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agouse DESTDIR now
Marc Chantreux [Mon, 10 Nov 2008 16:40:13 +0000 (17:40 +0100)]
use DESTDIR now

takes carre of changes in Makefile.PL about debian install

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFixes bug #2788 - CoinS support
Frederic Demians [Sun, 16 Nov 2008 08:50:54 +0000 (09:50 +0100)]
Fixes bug #2788 - CoinS support

1 In URL rft.tpages is replaced with rft.page. That's what
  Zotero expects.
2 TMPL_VAR NAME="size" is replaced with "pages" for 1.
3 TMPL_VAR NAME="publisher" is replaced with "publishercode"
  the correct value for rft.pub

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug #2794: Browse Shelf doesn't work with ISBN containing '-'
Frederic Demians [Mon, 17 Nov 2008 08:34:50 +0000 (09:34 +0100)]
Bug #2794: Browse Shelf doesn't work with ISBN containing '-'

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoadding "DROP TABLE" commands to several table definitions in kohastructure.sql
Henri-Damien LAURENT [Mon, 17 Nov 2008 17:00:06 +0000 (18:00 +0100)]
adding "DROP TABLE" commands to several table definitions in kohastructure.sql

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 1891 followup - remove dangling /TMPL_IF
Galen Charlton [Mon, 17 Nov 2008 15:21:33 +0000 (09:21 -0600)]
bug 1891 followup - remove dangling /TMPL_IF

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 1891 : bib-level itemtype was required in order to place a hold.
Ryan Higgins [Wed, 12 Nov 2008 03:05:03 +0000 (22:05 -0500)]
bug 1891 : bib-level itemtype was required in order to place a hold.

This patch removes some superfluous logic left over from early Koha
when a multi-step holds process allowed you to limit your choices to
specific biblioitems.itemtype values.  Code previously required a value
in biblioitems.itemtype in order to place hold.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix POD error
Galen Charlton [Tue, 11 Nov 2008 22:02:34 +0000 (16:02 -0600)]
fix POD error

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2775: adding method to clean syspref cache in C4::Context
Andrew Moore [Tue, 11 Nov 2008 20:34:13 +0000 (14:34 -0600)]
Bug 2775: adding method to clean syspref cache in C4::Context

C4::Installer provides a way to update the kohaversion syspref. Now that
C4::Context caches syspref values, any updated value through C4::Installer
is not being seen.

This patch adds a method to C4::Context to allow you to clean that
cache. Then, it calls that method when the kohaversion syspref is changed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoUpdated Italian translation files
Chris Cormack [Fri, 7 Nov 2008 22:33:23 +0000 (11:33 +1300)]
Updated Italian translation files

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoRemoving some unused stuff from print stylesheet, hiding Koha logo from print view.
Owen Leonard [Tue, 28 Oct 2008 00:31:25 +0000 (19:31 -0500)]
Removing some unused stuff from print stylesheet, hiding Koha logo from print view.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFix overdue list if you do not specify a branchcode.
Nahuel Angelinetti [Thu, 30 Oct 2008 09:35:59 +0000 (10:35 +0100)]
Fix overdue list if you do not specify a branchcode.

Before, if you do not provide a "branchcode" you have an empty csv export.
Now, if you have an empty branchcode you have all overdues listed in csv.
(I made a typo error in code)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoDo not allow an user to have an empty date
Nahuel Angelinetti [Fri, 31 Oct 2008 14:54:47 +0000 (15:54 +0100)]
Do not allow an user to have an empty date

If the user set an empty date as the expiration date during a patron modification, we recalculate the expiration date with sysprefs and the registration date.
Before, when you set an empty date, 0000-00-00 is put in the database (too bad).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoImprove C4::Charset::MarcToUTF8Record performance
Frederic Demians [Sat, 25 Oct 2008 08:38:37 +0000 (10:38 +0200)]
Improve C4::Charset::MarcToUTF8Record performance

A script like bulkmarkimport.pl spends most of the time
in C4::Charset::MarcToUTF8Record function, and
specifically in C4::Charset::char_decode5426
just initializing a hash. This patch moves this
hash outside function to avoid its initializing
each time the functon is called.

A test on a specific conversion script shows me
that performances were improved from 23s to 8s.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoA typo error was in the tmpl does not allow the user to sort by acquisition date.
Nahuel Angelinetti [Mon, 27 Oct 2008 09:37:46 +0000 (10:37 +0100)]
A typo error was in the tmpl does not allow the user to sort by acquisition date.

The patch fix this, after changing a bad "if".

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoDatabase connectivity cleanups
Clay Fouts [Thu, 30 Oct 2008 02:22:15 +0000 (19:22 -0700)]
Database connectivity cleanups

This patch employs process-local caching of systempreferences and
eliminates the "select 1" execution every time dbh() is called.
DBI::ping() is used instead.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2563: could not input into marc 008, fields 7-10 and 11-14
John Beppu [Wed, 5 Nov 2008 16:51:32 +0000 (10:51 -0600)]
bug 2563: could not input into marc 008, fields 7-10 and 11-14

You actually *could* input data into those fields, but it wasn't
immediately obvious, because the field size was "4" and the
value was "    ".  You couldn't type anything in until you
backspaced over the spaces that were there by default.

UPDATE 2008-11-05:  Make absolutely sure that those values
are 4 chars long (via JavaScript)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoCorrecting behavior of SpecifyDueDate and sticky due date options. Fixes Bug 2748.
Henri-Damien LAURENT [Wed, 12 Nov 2008 16:10:27 +0000 (17:10 +0100)]
Correcting behavior of SpecifyDueDate and sticky due date options. Fixes Bug 2748.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdd a dependance to CGI::Session::serialize::yaml 4.20
Nahuel Angelinetti [Wed, 5 Nov 2008 15:43:11 +0000 (16:43 +0100)]
Add a dependance to CGI::Session::serialize::yaml 4.20

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug #2760 wrong permissions for guided reports
Allen Reinmeyer [Wed, 5 Nov 2008 20:14:40 +0000 (14:14 -0600)]
Bug #2760 wrong permissions for guided reports

Guided reports and dictionary access was dependant on the editcatalogue permission instead of the report permission.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoUPDATE:Bug #2756 opacbookbag preference turns off add items to list
Allen Reinmeyer [Thu, 6 Nov 2008 20:43:26 +0000 (14:43 -0600)]
UPDATE:Bug #2756 opacbookbag preference turns off add items to list

There was a bug in the javascript that prevented the 'select all','clear all' and the 'add-to' list.  Javascript wasn't including basket.js on virtualshelves option.  Also, 'Save to Lists' was calling addtoshelf instead of addtolist. Functionality is now the same for virtualshelves regardless of opacbookbag status.

UPDATED:  Removed EXPR in TMPL_IF conditions

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoSome tab cleaning
Nahuel Angelinetti [Thu, 6 Nov 2008 08:41:48 +0000 (09:41 +0100)]
Some tab cleaning

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix the private shelf deletion in opac
Nahuel Angelinetti [Thu, 6 Nov 2008 08:34:06 +0000 (09:34 +0100)]
fix the private shelf deletion in opac

this patch add an "hidden" field in the template, that permit in C4::VirtualShelves::Pages to get the right(privates) shelves with
GetShelves in$
of always public shelves.
So when a private shelf is wanted to be deleted, the script watch only in public shelves if the shelf exists, and doesn't work.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdding javascript to let user click table cell to check containing checkbox.
Henri-Damien LAURENT [Wed, 12 Nov 2008 15:59:43 +0000 (16:59 +0100)]
Adding javascript to let user click table cell to check containing checkbox.

This is a usability improvement as it widens the target of the click. The script for moremember.pl includes code necessary to uncheck its sibling as per uncheck_sibling(). If this patch is approved I will look for other instances so that <td> interactions will be consistent.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agomake some line REAL comments, else the installer is buggous
Nahuel Angelinetti [Thu, 6 Nov 2008 10:58:38 +0000 (11:58 +0100)]
make some line REAL comments, else the installer is buggous

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoSquash warnings by checking if $type is defined before comparing it.
Joe Atzberger [Thu, 30 Oct 2008 05:10:57 +0000 (00:10 -0500)]
Squash warnings by checking if $type is defined before comparing it.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoThis file was missing from previous commit. bakertaylorimages.js manages the display...
Owen Leonard [Mon, 27 Oct 2008 19:41:01 +0000 (14:41 -0500)]
This file was missing from previous commit. bakertaylorimages.js manages the display of 'missing cover' text when Baker & Taylor images are used.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoOverhaul of cover images. Replaces Amazon's "no cover" image with styled text, addres...
Henri-Damien LAURENT [Wed, 12 Nov 2008 14:52:26 +0000 (15:52 +0100)]
Overhaul of cover images. Replaces Amazon's "no cover" image with styled text, addressing bug 2241. Adds the same "no cover" text for Google and Baker & Taylor images.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2707 - overdue rules not being deleted
John Beppu [Fri, 24 Oct 2008 14:45:24 +0000 (09:45 -0500)]
bug 2707 - overdue rules not being deleted

* I added some code to detect the rows which were blank,
  and I deleted them upon saving the form.
* Updated to get the categories from the database
  instead of hardcoding them.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoCirc cleanup.
Joe Atzberger [Thu, 30 Oct 2008 05:14:25 +0000 (00:14 -0500)]
Circ cleanup.

Removed unused $dbh variables, converted to loop_context_var instead of togglecolor.
Prevented double comparison in sort.  The rest is whitespace cleanup.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofollowup - make barcode_to_borrowernumber an internal function
Joe Atzberger (siptest [Tue, 4 Nov 2008 20:34:52 +0000 (14:34 -0600)]
followup - make barcode_to_borrowernumber an internal function

Set this function apart with _ since it is not OO like the rest.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2729: redundant call to C4::Biblio::get_biblio_authorised_values
Clay Fouts [Tue, 28 Oct 2008 00:04:25 +0000 (17:04 -0700)]
bug 2729: redundant call to C4::Biblio::get_biblio_authorised_values

Removes redundant and expensive call to C4:Biblio:get_biblio_authorised_values

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoStandardizing opac/circulation note terminology; Adding hint to opac/circulation...
Owen Leonard [Tue, 28 Oct 2008 00:31:34 +0000 (19:31 -0500)]
Standardizing opac/circulation note terminology; Adding hint to opac/circulation note entry

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoTerminology and spelling corrections. Fixes Bug 2724.
Owen Leonard [Tue, 28 Oct 2008 00:40:03 +0000 (19:40 -0500)]
Terminology and spelling corrections. Fixes Bug 2724.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoSpelling correction: catalogue -> catalog. Fixes Bug 2730.
Owen Leonard [Wed, 29 Oct 2008 14:16:41 +0000 (09:16 -0500)]
Spelling correction: catalogue -> catalog. Fixes Bug 2730.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdd fine amount to display on circ pages.
Michael Hafen [Tue, 14 Oct 2008 20:36:42 +0000 (14:36 -0600)]
Add fine amount to display on circ pages.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2682: followup - only do lc() on $op once
Galen Charlton [Thu, 23 Oct 2008 21:07:19 +0000 (16:07 -0500)]
bug 2682: followup - only do lc() on $op once

Per suggestion by Joe Atzberger.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFix for Bug 2682 ("Approving Multiple Tags - Doesn't Work"). Processing based on...
Owen Leonard [Wed, 15 Oct 2008 15:36:32 +0000 (10:36 -0500)]
Fix for Bug 2682 ("Approving Multiple Tags - Doesn't Work"). Processing based on value of submit buttons didn't take into account capitalization.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoUnravelling links in masthead. Regularize logic and improve readability.
Joe Atzberger [Fri, 19 Sep 2008 21:24:22 +0000 (16:24 -0500)]
Unravelling links in masthead. Regularize logic and improve readability.

Link to Tag Cloud displayed on Adv. Search page even when TagsEnabled was OFF.
This was due to unnecessary duplicative code for Adv. Search vs. other pages.
Note: with this revision, the link to "Advanced Search" will display on all pages,
even on the Advanced Search page itself.  This is in fact desirable, rather than
the set of links collapsing and changing position depending on page being viewed.
If the old premise were to be followed (that Adv. Search link should not display on its
own page), then the same interface sensibility should apply to ALL links in the
masthead: i.e., Tag Cloud link should not display on its own page, same for Browse
by Subject, Most Popular, etc.  I would argue even this is undesirable.  At most,
give the links in moresearches some IDs and let each page unlink/restyle the
"current" link with jquery.  IMHO, masthead itself should not be engage in such trifling
interface polishes.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug #2709 Cannot add from Search to New list
Allen Reinmeyer [Thu, 23 Oct 2008 19:16:18 +0000 (14:16 -0500)]
Bug #2709 Cannot add from Search to New list

While a new list was created, no subsequent call to add the biblio number was made,
thus a new empty list would be created every time.
Under the existing list add, the same code to add items would also apply to a new list,
so I refactored out the logic to add items and made a new subroutine.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofollowup to Calendar overhaul
Galen Charlton [Thu, 23 Oct 2008 17:34:05 +0000 (12:34 -0500)]
followup to Calendar overhaul

correct an errant "SELECT FROM" that slipped in

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBegin Calendar overhaul, turn on warnings.
Joe Atzberger [Fri, 19 Sep 2008 00:02:47 +0000 (19:02 -0500)]
Begin Calendar overhaul, turn on warnings.

Reuse SQL with placeholders where possible.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2543: follow-up patch
Galen Charlton [Thu, 23 Oct 2008 17:05:56 +0000 (12:05 -0500)]
bug 2543: follow-up patch

Add 'use C4::Reports' lines that original patch
omitted.

Note that original patch prevented these two reports
from even compiling.  Not good.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix for bug 2543: report output by tabulation a bit too literal
Jesse Weaver [Wed, 10 Sep 2008 00:31:31 +0000 (19:31 -0500)]
fix for bug 2543: report output by tabulation a bit too literal

This repurposes the Reports module for general reports, and moves its functionality to a different module, Reports::Guided. It also updates all of the reports that can export to correctly treat the 'tabulation' value of the 'delimiter' syspref.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoPatch security hole in vestigial report.
Joe Atzberger [Thu, 23 Oct 2008 16:01:03 +0000 (11:01 -0500)]
Patch security hole in vestigial report.

IMHO, this report should be removed in entirity because of its faulty
construction and total inability to distinguish between register "tills".
That is, it appears to be a valid accounting measure but isn't.
In any case, it let's not let just anybody run it!

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoSteamlining javascript for cloning additem block and tweaking style.
Henri-Damien LAURENT [Wed, 12 Nov 2008 14:04:57 +0000 (15:04 +0100)]
Steamlining javascript for cloning additem block and tweaking style.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoAdding some body IDs to OPAC pages to enable finer per-page control via CSS.
Owen Leonard [Fri, 17 Oct 2008 14:19:12 +0000 (09:19 -0500)]
Adding some body IDs to OPAC pages to enable finer per-page control via CSS.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoChanging checkboxes to radio buttons (as it is in the OPAC), since you can't place...
Owen Leonard [Mon, 20 Oct 2008 15:42:59 +0000 (10:42 -0500)]
Changing checkboxes to radio buttons (as it is in the OPAC), since you can't place a hold on more than one specific item. Also includes some markup cleanup.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoShow card number (non-editable) on opac-userupdate.pl. Also correctly formatting...
Owen Leonard [Fri, 17 Oct 2008 14:19:24 +0000 (09:19 -0500)]
Show card number (non-editable) on opac-userupdate.pl. Also correctly formatting expiration date.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years ago1571
John Beppu [Wed, 22 Oct 2008 20:34:06 +0000 (15:34 -0500)]
1571

made the description show up by running the query w/ the required number of params

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug #2030 z3950 search function does not filter
Allen Reinmeyer [Wed, 22 Oct 2008 17:20:49 +0000 (12:20 -0500)]
Bug #2030 z3950 search function does not filter

Entering a term in the z3950 search box does not filter the results.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2692: remove escape="url" from opac-facets.inc
Galen Charlton [Wed, 22 Oct 2008 20:22:46 +0000 (15:22 -0500)]
bug 2692: remove escape="url" from opac-facets.inc

Based on Owen Leonard's patch, but redone to exclude
a dependency on an earlier unapplied patch.

For future enhancement, limit_cgi and the like should
probably not be constructed directly in C4::Search.
Instead, it should pass back a representation of the search
that the template can use to construct the appropriate URLs.
Done right, that would also make it easier to implement
things like search history.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoOPAC-side ISBN display fix (Bug 2592)
Owen Leonard [Wed, 15 Oct 2008 14:04:54 +0000 (09:04 -0500)]
OPAC-side ISBN display fix (Bug 2592)

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoTwo template bug-fixes: removing debugging output from opac-detail.tmpl, and turning...
Owen Leonard [Tue, 14 Oct 2008 18:50:47 +0000 (13:50 -0500)]
Two template bug-fixes: removing debugging output from opac-detail.tmpl, and turning off html-escaping in addbooks.tmpl to prevent incorrect HTML output. Need to figure out how to allow HTML tags in titles /and/ do search term highlighting.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoMarkup corrections, style fixes, and other minor bugs, including fix for Bug 2679...
Owen Leonard [Wed, 15 Oct 2008 15:18:14 +0000 (10:18 -0500)]
Markup corrections, style fixes, and other minor bugs, including fix for Bug 2679 ("Dates Changing on Funds When Editing")

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2660: Add command-line options to overdue notice script.
Ryan Higgins [Fri, 17 Oct 2008 03:25:27 +0000 (22:25 -0500)]
Bug 2660: Add command-line options to overdue notice script.

This commit adds two options to the overdue_notices.pl script.
The notices are now generated in one of two modes: default or triggered.
In default mode, every time the script runs, a notice is generated if an item
is overdue within a notice date range.  This mode is suitable for a weekly cron
(or manual run), but the notice triggers should be syncronized with the cron script such that
the script is run once per notice date range.  Otherwise, duplicate messages will
be generated ( or no notice generated if a notice date range passes without the script being run).
Triggered mode is suitable for a nightly cron job: a notice is generated only on those
days that an overdue item enters a notice date range.  This mode is susceptible to message
loss when the cron script fails to run, or when notice triggers are edited.

A second flag is added: --list-all, which causes items.content to list all currently overdue items.
Without this flag, only items that are overdue within the given notice's date range are listed on
that notice.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoReport to user the connections errors to z39.50 server, like timeout(10007), and...
Nahuel Angelinetti [Fri, 17 Oct 2008 07:38:13 +0000 (09:38 +0200)]
Report to user the connections errors to z39.50 server, like timeout(10007), and refused(10000).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofollowup - use &amp; in place of &
Galen Charlton [Thu, 16 Oct 2008 20:45:41 +0000 (15:45 -0500)]
followup - use &amp; in place of &

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoBug 2627: Allow Unicode data in import_borrowers, expand feedback on errors.
Joe Atzberger [Fri, 19 Sep 2008 00:02:45 +0000 (19:02 -0500)]
Bug 2627: Allow Unicode data in import_borrowers, expand feedback on errors.

Date fields are now checked against syspref and iso regexps before attempting
to convert or insert them.  The problem characters were non-ASCII diacriticals.
Note: this may rely on improvements in the current 0.54 version of Text::CSV and
Text::CSV_XS, rather than the Koha minimum of 0.01 and 0.32, respectively.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agofix calls to get_template_and_user in label-item-search.pl
Michael Hafen [Thu, 16 Oct 2008 19:59:44 +0000 (13:59 -0600)]
fix calls to get_template_and_user in label-item-search.pl

remove extra flagsrequired line.
move call in first branch to the top.
  This will be important is IndepenantBranches code is later added to,
for example, C4::Items::get_itemnumbers_of()

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug in 'Add/Change link to item details...' I missed Previous checkouts area
Michael Hafen [Tue, 7 Oct 2008 17:30:27 +0000 (11:30 -0600)]
bug in 'Add/Change link to item details...' I missed Previous checkouts area

This turns the barcode into a link to moredetail.pl in the Previous
checkouts area of the circulation page, so it matches the Todays
checkouts area.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>