Style improvements to moredetail.tmpl; Bug fix for removal of virtual shelf items in opac.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Beginning some reformatting of advanced search interface

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Minor reformatting of error messages.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix to enable reading history in the staff client.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

missing "

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Search.pm Bugfixing

Getting Search.pm air tight ... cleaned up some local variables
that were declared global

fix to asynchronous federated searching lost since dev_week, immediate
use is authority search

template fixes to item-level itemtypes and bib-level itemtypes

temp workaround to javascript problems preventing item edits

fix to installer

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

improve embedded documentation and perldoc

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

s/holded by/maintained/

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Improvements to nomenclature re: authority tag, making .tip global

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

important: DBD::mysql 4.004 or later required

This version of DBD::mysql is required in order to have
proper handling of UTF8 strings.

Also bumped version of YAML::Syck down to 0.71 to
match Debian stable package.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for 1582, if independent branches is on, you cant return to

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixed typo in new borrower column

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

session management: use YAML::Syck for serialization

When using mysql and a sufficiently recent version
of DBD::mysql that actually respects the mysql_enable_utf8
option, setting the current branch to a name that
includes a diacritic causes the session to fail
and forces the user to the login screen upon
clicking another link.

This turned out to be due to the default (Data::Dumper)
serialization used by CGI::Session, which truncated the
session object at the diacritic.  By enabling
that module's YAML serialization option, the problem
was resolved.

This patch introduces a dependency on the YAML::Syck
module.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

UTF8 and mysql: enable UTF8 mode correctly

Doc for DBD::mysql states that if not setting
mysql_enable_utf8 as part of the database
connect(), must do it before doing "set names utf8"

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

adding change to syspref for finesmode.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

adding 'exempt fine on return' option.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

cleanup in memberentry,categories.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

revert to sql in updateitem.pl

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for 1704, now if autoitemreturns is off you get a dialogue warning a

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Getting rid of noisy warn

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Taking out warn

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1666

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Input.pm - perldoc correction

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

about.pl -- get apacheVersion for etch-like setups

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1164, child branch not defaulting to guarantor's on add child

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

improving visual display of sysprefs, re-organizing

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for 1654

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1014, internal server error on unknown borrower

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

web installer: clean up warns; improve naming of Nozebra op

The former 'Nozebra' op has been renamed to 'SetIndexingEngine'
to avoid having a 'Nozebra' op and a 'NoZebra' parameter
distinguished only by case.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

BIG COMMIT: minimal fix to authorities search

This is a minimal fix -- pname authorities work propertly, but nothing
else has been tested yet

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Big bugfix for bug 1631

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for 1699, cant change category type

Now you can change a borrower to any category

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

category template fix for bug 1699

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1686, moremember.pl doesnt know if a borrower is a child

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1691

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for typo in Insert line in updatedatabase.pl

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Adding OPACItemsResultsDisplay syspref & bumping to version 036

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

removing some code that is for staff, not for opac

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

replacing SHELF_LOC by LOC, as decided with kados on the chat

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fix to handle notforloan authorised values (we now handle wthdrawn, itemlost, damaged AND notforloan fields)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

mapping items.onloan to 995$n (to handle biblio status from zebra)

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fix typo: "Ok" => "OK"

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

removed unmatched /TMPL_IFs

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

prefixing all holdings auth values with HINGS

modrequest.pl did not previously have auth checking, security bug!

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

removing unused ReadingHistory syspref

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fix for bug 1696: Reading record page fails

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

removing postgres sql from main installaer dir, it exists in data/Pg/, though in a different form, Chris, please double-check that I haven't removed the latest one and if so, git revert and git mv it into the right slot.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fix to bug 1569

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

WARNING: BIGFIXING 670

670 is primarily about the status of a biblio or item that's got a
hold on it ... specifically the 'in transit' and 'waiting' status.
It applies to the following pages.

* request.pl - tested
* detail.pl - tested
* circulation.pl - tested
* moremember.pl - tested
* opac-user.pl - doesn't show transit status, but only shows waiting
when item has arrived at the pickup library
* opac-detail.pl - doesn't show hold statuses

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

bug 1368 - remove FOREIGN_KEY_CHECKS = 0 from installer

[1] Web installer no longer sets FOREIGN_KEY_CHECKS = 0
    when loading frameworks and sample SQL.
[2] Removed FOREIGN_KEY_CHECKS = 0 from SQL scripts
[3] Fixed FK issues in en/optional/sample_patrons.sql

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixed typo in directory name

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Updating README.debian

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

IMPORTANT - replaced TransformMarcToKoha

Replaced with FasterTransformMarcToKoha
from a previous commit.  Main differences are:

[1] At least twice as fast because of improvement
    in algorithm for processing the MARC record --
    each tag is processed only once.
[2] Fixed bug where biblio.notes would end up with
    an extra ' | ' at the end.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

bulkmarcimport: enable MARC-8 to UTF-8 conversion

Enabled automatic conversion of MARC-8 records to
UTF-8.  Record is converted if its Leader/09 contains
a blank and the -s (skip) option hasn't been supplied
on the command-line.  Any record that cannot be converted
to UTF-8 is skipped.

Also now use Unicode Normalization Form C (NFC) for
records converted from MARC-8.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixed C4::Dates usage that caused crash of orderreceive.pl

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

removed extraneous comments

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

improved error detection in AddBiblioAndItems

Introduced new C4::Biblio function CheckItemPreSave,
which checks for duplicate barcodes and invalid
branch codes.  Not yet sure whether this function
needs to be exported or whether it will just be
used internally to C4::Bibli.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixed error message when branch cannot be saved

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

removed superfluous comments

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

C4::Biblio::AddBiblioAndItems - added duplicate barcode check

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

bulk MARC record import - speed improved

Changes to improve speed of MARC bib and item
imports:

[1] Turn off autocommit and commit database
    transactions in larger batches.
[2] Introduce a new C4::Biblio function (AddBiblioAndItems)
    to combine AddBiblio and AddItems -- this is faster
    because we are not parsing the MARC XML of the biblio
    every time we add an item.
[3] Introduce FasterTransformMarcToKoha, which is much
    faster than TransformMarcToKoha.  The new version,
    which will replace the old one once it has been
    fully tested, scans through each field in the
    MARC record just once, instead of potentially
    dozens of times.
[4] Remove code in bulkmarcexport that moved the
    item tags to separate MARC::Record objects.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

IMPORTANT: BUGFIXING STATUSES

Major bugfixes:
* Circulation status in moredetail.pl now correctly displays On loan
status and Date due
* Bugfixes on Status column in detail.pl
   * Removed hard-coded English strings from status column in detail.pl
      * Added missing auth values for lost and damaged statuses, sane
defaults if those auth
     values don't exist
        * Added missing 'On hold' status and 'Hold waiting' status
display

Medium bugfixes:
* Now correctly shows itemtype at level specified in systempreference
* Uses itemtypeimage for display, image title is full itemtype
description

* Fixed Location column concatenation between branchname location and
itemcallnumber
  * broke out Location (branch), Collection (items.location)
      Call Number (itemcallnumber) into their own columns
        * Added auth value display for items.location

Minor fixes:
* detail.pl didn't show dates correctly
* nomenclature s/Checked out/On loan/ in opac-detail.tmpl
* s/Book/Item/ in my $desc="Item Returned
".$iteminfo->{'barcode'}; in Circulation.pm
* request.tmpl: s/date_due/onloan/ to display date due
* Fixed SimilarItems, XISBNSimilarItems

NOTE: Needs to be ported to OPAC

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

forgot to add imageurl to OPAC

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Synching opac with fixes to reserves adding back dev_week opac reserve cancel feature that was removed Could use some style improvements

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

improvements for translation, switch to use same views as rest of biblio

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

bugfixing request.pl

Major Fix:
Fixing bug where 'expected' label existed for items that
were 'waiting'

Minor Cleanup:
Show correct statuses
Show itemtypes at correct levels depending on
global system preference
Display branch names, not branch codes
Adding in visibility option for 'canreservefromotherbranches' syspref

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

show itemtypes at level specified in syspref for holds

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixing requests.tmpl, adding side-tabs (views)

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Warning: big commit Fixing moredetail.pl

Previously, about 50% of the data on this page was either incorrect or missing.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

adding auth value for 'Missing in Holdqueue'

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Doh, typo, fixed

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Reserves not made at priority 0 if ReservesNeedReturns is switched on

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Missed one priority == 0

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Priority = 0 does not equal reserve found, only found='W' equals reserve found

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

An item is only waiting if found is set to W in the reserves table

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for bug 1703

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

nomenclature cleanup in the OPAC detail and user pages

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fix for bug 1688

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

expandtab, retab, tabstop=4

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Revert "Merging hdl's Search.pm changes"

This reverts commit 51ec728f7b358b8ca4ef8f3cdd44cb976d907b90.

That commit basically reverted 95% of the status handling I'd done
last week ...

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

retab with tabstop=4 and expandtab on

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Warning: Big Commit. Fixing Virtual Shelves

  * prior to this commit, virtual shelvesn't did not function in
    the OPAC! Now they do, except for deletion from virtual shelves
    in list form
  * I've re-named 'Virtual Shelves' to 'Lists' as per our agreed
    upon convention

  * while vshelves aren't perfect yet, they're in enough of a working
    state for the RC1 now

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

adding ports information

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Minor correction to template markup and change to script to allow for more clickable <label>s.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

allow use of older version of File::Temp

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

more updates to README.debain

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixed invocation of zebraqueue_daemon.pl

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

circ: do not crash when 'returning' item that was not issued

When attempting to return an item that was not actually
on loan, would crash because GetItemIssue did not return
biblionumber in hash.  Add call to get biblionumber
directly.

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixes to README.debian

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

adding a note on how to remove zebra daemons from startup

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

removed extra KOHA_CONF line

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

various installer changes

[1] Map new directory misc/bin to SCRIPT_DIR
    instead of SCRIPT_DIR/bin.
[2] rewrite-config.PL no longer removes execute mode
[3] Add new Zebra startup script to rewrite-config.PL
    list.
[4] Added KOHA_USER and KOHA_GROUP to rewrite-config.PL

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Several important commits:

  * adding zebra daemons for managing server and queue processes
  * improvements to the README.debian file
  * Fixes to Search.pm since last series of commits broke zebra-based
    searching (again)
  * moving some files to new misc/bin and misc/cronjobs

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

adding debian-specific installation guide

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

nomenclature improvements, updating README.txt

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

missing < in about page

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

updating versions for debian etch packages

Signed-off-by: Joshua Ferraro <jmf@liblime.com>

fixing version numbers in Makefile.PL, adding a

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>

Fix for Bug 1685, if patronimages syspref is off, tabs disappear from moremember.pl. Renegade TMPL_IF taken out.

Signed-off-by: Chris Cormack <crc@liblime.com>
Signed-off-by: Joshua Ferraro <jmf@liblime.com>