Bug 17843: Replace C4::Koha::getitemtypeinfo with Koha::ItemTypes
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 4 Jan 2017 09:30:47 +0000 (10:30 +0100)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 5 Jul 2017 16:42:21 +0000 (13:42 -0300)
commit091d6c513bcbee224ff06477e79be48cea7fe825
treea1b8c7e317db871beda4ac850116d22adb56a59f
parentc69e02c4419a2d4a7ca31af6441081cadd4e51b3
Bug 17843: Replace C4::Koha::getitemtypeinfo with Koha::ItemTypes

The C4::Koha::getitemtypeinfo subroutine did the almost same job as
GetItemTypes. On top of that it returned the imageurl value processed by
C4::Koha::getitemtypeimagelocation.
This value is only used from the 2 [opac-]shelves.pl scripts. Then it's
better not retrieve it only when we need it.

Test plan:
Play with the different scripts touched by this patch and focus on item
types. The same description as prior to this patch must be displayed.
Note that sometimes it is not the translated description which is
displayed, but that should be fixed on another bug report. Indeed we do
not expect this patch to change any behaviors.

Signed-off-by: Lari Taskula <lari.taskula@jns.fi>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
15 files changed:
C4/Biblio.pm
Koha/Template/Plugin/ItemTypes.pm
acqui/orderreceive.pl
catalogue/getitem-ajax.pl
circ/transferstoreceive.pl
circ/waitingreserves.pl
members/summary-print.pl
opac/opac-browser.pl
opac/opac-search.pl
opac/opac-shelves.pl
opac/opac-tags_subject.pl
svc/checkouts
svc/holds
t/db_dependent/Koha.t
virtualshelves/shelves.pl