Bug 24964: [19.11.x] Do not fetch all patrons for owner/users of funds
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 6 Apr 2020 09:44:18 +0000 (11:44 +0200)
committerJoy Nelson <joy@bywatersolutions.com>
Wed, 29 Apr 2020 15:57:57 +0000 (15:57 +0000)
commit300dbea81219245614d95599c7cd98c51a005242
tree00a2051b974ba71ed8a5320682184aa29a0c5dc2
parent96956fee2440f20a112bc1413253d6043ada704f
Bug 24964: [19.11.x] Do not fetch all patrons for owner/users of funds

admin/add_user_search.pl sets 'patrons_with_acq_perm_only', to only
retrieve patrons with acq (order_manage) permissions.

The original bug was hidden in the existing code, but the behavior was
terrible.
To prevent patrons matching the permissions contrainst to be hidden, we
fetched ALL the patrons from the DB, then filtered them depending on
their permissions. This might have awful performance on DB with lot of
patrons.

So basically with this patch we are adding the pagination back to the
"owner/users for funds" feature, as the permission filtering is now done
at DB level.

Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
koha-tmpl/intranet-tmpl/prog/en/modules/common/patron_search.tt