Bug 27180: Update fines on holidays
authorNick Clemens <nick@bywatersolutions.com>
Wed, 9 Dec 2020 15:39:09 +0000 (15:39 +0000)
committerFridolin Somers <fridolin.somers@biblibre.com>
Wed, 20 Jan 2021 08:57:15 +0000 (09:57 +0100)
commit69821f7aba39009b850aef5716a0818f3cb61d54
treeb84968ef89a8784be5d6a2522083a1898016e8c8
parentf4a8aa75ab948cc4476b01b69f6b2e1623443828
Bug 27180: Update fines on holidays

This patch removes code that prevents fines from being update on holidays.
The fines are already being calculated, and that takes the calendar into account if
needed, so fines won't be assessed on holidays if they shouldn't.

To test:
 1 - set finesCalendar to 'ignore'
 2 - Checkout an item due yesterday
 3 - Ensure circ rules have a fine amount set
 4 - Make today a holiday
 5 - run fines.pl
 6 - No fine assessed
 7 - Apply patch
 8 - run fines.pl
 9 - Fine assessed!
10 - set finesCalendar to 'use'
11 - checkout an item, due yesterday
12 - run fines.pl
13 - no fine assessed

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 80e1b4e66f01a07cad9bf37625d879f649edf52a)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
misc/cronjobs/fines.pl