Bug 26208: Perform batch checkin/renewals serially rather than asynchronously
authorNick Clemens <nick@bywatersolutions.com>
Thu, 3 Dec 2020 19:13:15 +0000 (19:13 +0000)
committerFridolin Somers <fridolin.somers@biblibre.com>
Thu, 25 Feb 2021 11:11:44 +0000 (12:11 +0100)
commitb150fdc79247b6fedda5054b374aafe8292ee3fa
tree04eb1da1c1da779ebcafecf1b86bba6e8cdb968f
parente1f35cf3474952a851e62a2366fd520f0b413228
Bug 26208: Perform batch checkin/renewals serially rather than asynchronously

The issue here seems to be that when multiple requests hit at once they may not register that the renewal
performed by the request should lift restrictions on the account.

To mitigate this we can simply perform the renewals one after the other.

To test:
1 - have multiple overdue items on one patron
2 - run overdues.pl with triggers set to generate a restriction
3 - renew all overdues with the Renew All button
4 - restriction is not removed even though patron no longer has overdue items
5 - Apply patch
6 - Make all items overdue again
7 - Click Renew All
8 - Items are renewed and restriction removed
9 - Checkout items to patron again (overdue or not)
10 - Click 'Select all' in checkin column
11 - Click 'Renew/Checkin selected items'
12 - Confirm checkin succeeds as before patches

Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Bug 26208: (follow-up) Remove debugging statements

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit a825c729386e7f528846445937e00eda92f01f68)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
koha-tmpl/intranet-tmpl/prog/js/checkouts.js