Bug 26364: Remove false matches on isbn
authorNick Clemens <nick@bywatersolutions.com>
Wed, 9 Sep 2020 13:33:17 +0000 (13:33 +0000)
committerFridolin Somers <fridolin.somers@biblibre.com>
Fri, 8 Jan 2021 06:38:05 +0000 (07:38 +0100)
commitc6ce4f6fc8f4e0177193366dcbf11a79af2aef4e
treef7d522087a4c626c1f4975ec484c6fe678eb5745
parentadb5ed80372c7a0faee2b92a244e582fb127b285
Bug 26364: Remove false matches on isbn

The test here was returning 0590353403 when searched for 9780590353403
because of the regex matching

Koha doesn't work this way unless SearchWithISBNVariations is set to 'search'
and you use a dropdown to select ISBN for searching

To test:
1 - Search catalog for nb=9780590353403
2 - Confirm you don't have results, or delete the records with results
3 - Add isbn 0590353403 to a record
4 - Repeat search, fails
5 - Enable SearchWithISBNVariations
6 - Repeat search, fails
7 - Go to advanced search, select ISBN, search for 9780590353403
8 - Get results

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 854d404a9c161845731d39980165f8d641713a80)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
t/db_dependent/XISBN.t