Bug 28912: Prevent Pseudonymization to be set if bcrypt_settings not set
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Fri, 27 Aug 2021 14:56:08 +0000 (16:56 +0200)
committerKyle M Hall <kyle@bywatersolutions.com>
Fri, 10 Sep 2021 12:06:14 +0000 (08:06 -0400)
commitf73868b8ee121103e7406e26b20e9cf3ccae4eb7
tree13cb4628b00ab8d71874c1c5e280a71f0e34d4e5
parent60873e6030b63ea6c2f13dadcdf84e63362d4796
Bug 28912: Prevent Pseudonymization to be set if bcrypt_settings not set

If Pseudonymization is set but the bcrypt_settings config used by the
feature is not set, then there is an ugly 500 on checking out.

bad bcrypt settings at /kohadevbox/koha/Koha/PseudonymizedTransaction.pm line 116.

However it's pretty hard to handle correctly this exception (and that's
why it hasn't be done initially). However we could prevent the pref to
be turned on if the config entry is not present.

Test plan:
Remove the bcrypt_settings from the config
Try to turn the syspref on
Add the config
Try to turn the syspref on/off

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
JD amended patch: fix qa failures

Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
admin/preferences.pl
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt