From 088a610682f1a1be3fd05b64c5080faa0ff7cfd7 Mon Sep 17 00:00:00 2001 From: Victor Grousset/tuxayo Date: Thu, 23 Jan 2020 15:55:18 +0100 Subject: [PATCH] Bug 24494: tests: 00-valid-xml.t shouldn't check node_modules == Test plan == - work with SCSS (just recompile it if you never did) - https://wiki.koha-community.org/wiki/Working_with_staff_client_SCSS - now you have a node_modules directory - prove -r t/00-valid-xml.t - it should fail on files in node_modules - apply this patch - prove -r t/00-valid-xml.t - it should work - sabotage a legitimate XML file, like etc/SIPconfig.xml - prove -r t/00-valid-xml.t - it should fail, good the test is still useful - undo the sabotage Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Joy Nelson --- t/00-valid-xml.t | 1 + 1 file changed, 1 insertion(+) diff --git a/t/00-valid-xml.t b/t/00-valid-xml.t index 2c5393abd7..d19b4e68d1 100644 --- a/t/00-valid-xml.t +++ b/t/00-valid-xml.t @@ -30,6 +30,7 @@ find({ no_chdir => 1, wanted => sub { my $file = $_; + return if $file =~ /node_modules/i; return unless $file =~ /(\.xml|\.xsl|\.xslt|\.xsd)$/i; my $dom; eval { $dom = $parser->parse_file($file); }; -- 2.39.5