From 1c1167b409ca2cdd9a20ae55278fb078aa14e8fd Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Mon, 9 May 2016 14:23:34 -0400 Subject: [PATCH] Bug 16481 - Report menu has unexpected issues This patch corrects a problem with the reports toolbar include file which can cause a problem with the "duplicate" button. The duplicate button passes the entire report SQL as a URL parameter, but the template variable was not escaped as a URL variable. This patch also adds the "uri" filter to the report name and notes fields just to be safe. To reproduce the bug, create a new SQL report using the SQL in the bug report. When you run the report you should see a broken "Duplicate" button. Apply the patch and run the report again. The duplicate button should look correct and work correctly. Signed-off-by: Aleisha Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit 8aec387198ac589d4179064123a0f6e213efa5f1) Signed-off-by: Julian Maurice --- koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc index 36be0d3092..d6bf5d1456 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc @@ -19,7 +19,7 @@ [% END %] -- 2.20.1