From 695e20e947f7f18136b3c10ef1e254fa539e9875 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Fr=C3=A9d=C3=A9ric=20Demians?= Date: Sat, 6 Aug 2016 10:13:18 +0200 Subject: [PATCH] Bug 17053 Clearing search term in Reports MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit If you click the clear button to clear the search term it does take the search term away. However, the next time you click on "Saved reports" the search term is still there. TO TEST: 1. Reports > Use saved 2. Filter on anything (date/author/keyword). Let say "foo" in keyword. 3. Click the Clear link on the Filter form. You can see that "foo" is removed from keyword, and all the saved reports are displayed. 4. Click "Saved Reports" on the left. You can see that "foo" reappears in keyword filter. 5. Apply the patch, and repeat steps 2-4. Signed-off-by: Jesse Maseto Signed-off-by: Katrin Fischer Signed-off-by: Kyle M Hall (cherry picked from commit aa0e27ea08cf0d9a1ff46b061cc38d2b15fa66e7) Signed-off-by: Frédéric Demians (cherry picked from commit 86985bffc49977c97c6de98edc68ad3c3f917039) Signed-off-by: Julian Maurice --- reports/guided_reports.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/reports/guided_reports.pl b/reports/guided_reports.pl index d50c5b3df9..bff80947b5 100755 --- a/reports/guided_reports.pl +++ b/reports/guided_reports.pl @@ -71,7 +71,7 @@ my ( $template, $borrowernumber, $cookie ) = get_template_and_user( my $session = $cookie ? get_session($cookie->value) : undef; my $filter; -if ( $input->param("filter_set") ) { +if ( $input->param("filter_set") or $input->param('clear_filters') ) { $filter = {}; $filter->{$_} = $input->param("filter_$_") foreach qw/date author keyword group subgroup/; $session->param('report_filter', $filter) if $session; -- 2.20.1