From 6c44d1f4645b4c98577d6af23b05b9608b421253 Mon Sep 17 00:00:00 2001 From: Lari Taskula Date: Thu, 30 Jul 2015 18:34:49 +0300 Subject: [PATCH] Bug 14621: Messaging preferences table needs to be sorted I have been working with messaging preferences and I noticed a weird issue in Firefox on Ubuntu. On messaging preferences page, the table is unsorted and the content in rows are generated randomly on every page refresh. When you select/deselect checkboxes and refresh the page (without posting the changes), Firefox will remember your choices. Now the issue is that when the table is unsorted and the rows keep changing on page refresh, Firefox has trouble remembering your choices. This makes it appear as if the checkboxes are magically changing values on each page refresh. Here is a patch that prevents this problem by sorting the messaging settings. Signed-off-by: Chris Cormack Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 46ac35f8e11c06a784ca309b0dc876aff9469edb) Signed-off-by: Chris Cormack --- C4/Members/Messaging.pm | 3 +++ 1 file changed, 3 insertions(+) diff --git a/C4/Members/Messaging.pm b/C4/Members/Messaging.pm index be65d3dbef..76a3dadfef 100644 --- a/C4/Members/Messaging.pm +++ b/C4/Members/Messaging.pm @@ -217,6 +217,9 @@ END_SQL } my @return = values %$choices; + + @return = sort { $a->{message_attribute_id} <=> $b->{message_attribute_id} } @return; + # warn( Data::Dumper->Dump( [ \@return ], [ 'return' ] ) ); return \@return; } -- 2.39.2