From 7519003be921cde17f8547fb242635b109bfb0a1 Mon Sep 17 00:00:00 2001 From: Amit Gupta Date: Tue, 15 Aug 2017 14:06:47 +0530 Subject: [PATCH] Bug 19108 - Stored XSS in authtypes.pl To Test 1. Hit the page /cgi-bin/koha/admin/authtypes.pl?op=add_form 2. Add a text in the field Description that contains js 3. Save the page. 4. Notice js is execute 5. Apply patch and reload, the js is escaped Signed-off-by: Katrin Fischer Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart (cherry picked from commit bc780f588bc908f8b1d0da8987b20914996d942c) Signed-off-by: Fridolin Somers (cherry picked from commit 520388dc1d6f3e0e6ada332cf232784e4e737834) Signed-off-by: Katrin Fischer --- koha-tmpl/intranet-tmpl/prog/en/modules/admin/authtypes.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authtypes.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authtypes.tt index 7cad110280..3b83e6fb61 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authtypes.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authtypes.tt @@ -160,8 +160,8 @@ [% FOREACH authority_type IN authority_types %] [% authority_type.authtypecode %] - [% authority_type.authtypetext %] - [% authority_type.summary %] + [% authority_type.authtypetext |html %] + [% authority_type.summary |html %] [% authority_type.auth_tag_to_report %]