From b4d9ed346ed193e7a72d48745ad26b55737bfa7d Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Mon, 28 May 2018 15:19:09 -0300 Subject: [PATCH] Bug 20811: Fix wrong usage of ModBiblio Since commit cefa7c21e28b88351ee8ae0dfefb80a515323df9 Bug 5635: bulkmarcimport new parameters & features AddBiblio call has been replaced with ModBiblio, but the return values are different. We should not replace the value of $biblionumber with what returns this subroutine. Test plan: If you are familiar with bulkmarcimport.pl you should know what to test, I am not. Signed-off-by: Martin Renvoize Signed-off-by: Marcel de Rooy Signed-off-by: Nick Clemens (cherry picked from commit d15185025a146656a1ad0d7d5a8eb261581c0f1e) Signed-off-by: Martin Renvoize (cherry picked from commit c76d5b4b4a531e408fbaa5a9a7a523a749638764) Signed-off-by: Fridolin Somers (cherry picked from commit 0fb5af564b9b91cd9412f10f5f8e2e1377c73eab) Signed-off-by: Fridolin Somers --- misc/migration_tools/bulkmarcimport.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/misc/migration_tools/bulkmarcimport.pl b/misc/migration_tools/bulkmarcimport.pl index 3e48a856fa..389bafb0e1 100755 --- a/misc/migration_tools/bulkmarcimport.pl +++ b/misc/migration_tools/bulkmarcimport.pl @@ -419,7 +419,7 @@ RECORD: while ( ) { if ($biblionumber) { eval{$biblioitemnumber=GetBiblioData($biblionumber)->{biblioitemnumber};}; if ($update) { - eval { ( $biblionumber, $biblioitemnumber ) = ModBiblio( $record, $biblionumber, GetFrameworkCode($biblionumber) ) }; + eval { ModBiblio( $record, $biblionumber, GetFrameworkCode($biblionumber) ) }; if ($@) { warn "ERROR: Edit biblio $biblionumber failed: $@\n"; printlog( { id => $id || $originalid || $biblionumber, op => "update", status => "ERROR" } ) if ($logfile); -- 2.20.1