From ff2b5116e9edb5ce62212a8f25518bc1647b19b9 Mon Sep 17 00:00:00 2001 From: Marc Date: Fri, 7 Oct 2016 11:03:45 +0200 Subject: [PATCH] Bug 11217: The # in accountlines descriptions makes them un-writeoffable MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit This patch adds escaping to url params in mambers/pay.pl To test: - Apply patch - Go to Home > Patrons > Manual invoice and create an invoice with a description containing a # - Go to tab "Pay fines" - Write off the fine Expected result: Fine is written off and does no longer display in pay tab. Signed-off-by: Claire Gravely Signed-off-by: Nick Clemens Signed-off-by: Brendan Gallagher (cherry picked from commit 692014c817b58876042ab03d71bde0c2cce7e571) Signed-off-by: Frédéric Demians --- members/pay.pl | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/members/pay.pl b/members/pay.pl index 8747dfa798..9d5a37a9a6 100755 --- a/members/pay.pl +++ b/members/pay.pl @@ -173,8 +173,8 @@ sub redirect_to_paycollect { $redirect .= get_for_redirect( 'amount', "amount$line_no", 1 ); $redirect .= get_for_redirect( 'amountoutstanding', "amountoutstanding$line_no", 1 ); - $redirect .= get_for_redirect( 'description', "description$line_no", 0 ); - $redirect .= get_for_redirect( 'title', "title$line_no", 0 ); + $redirect .= uri_escape_utf8( get_for_redirect( 'description', "description$line_no", 0 ) ); + $redirect .= uri_escape_utf8( get_for_redirect( 'title', "title$line_no", 0 ) ); $redirect .= get_for_redirect( 'itemnumber', "itemnumber$line_no", 0 ); $redirect .= get_for_redirect( 'notify_id', "notify_id$line_no", 0 ); $redirect .= get_for_redirect( 'notify_level', "notify_level$line_no", 0 ); -- 2.20.1