Bug 36190: Fix problems found by test opac-shelves - forms were stateless - changed to GET sco-main - forms stateless - changed to GET ** untested because sco + auth is broken smart-rules.tt - JS form template - added placeholder 'cud-' op ill-requests - added cud- tp ops ** tested comments, but not checkout, simple changes boraccount - removed repeated op - updated script patroncards/edit-batch - add placeholder 'cud-' op patroncards/manage - add placheholder 'cud-' op elasticsearch/mappings - separate forms - this could use a style follow-up, but makes more sense separate I think reports/dictionary - stateless - changed to GET guided_reports_start - stateless - changed to GET suggestion/suggestion - add placeholder 'cud-' op inventory - filed bug 36305, needs more handling Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Bug 35329: Move patron search to modal - edit-batch Test plan: Create new patron card batch Keep the textarea empty and click "Add patron(s)" to open the modal There is a special feature here, the "checkbox" column is displayed and you can select several patrons and click "Add selected patrons". Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Bug 36084: svc - creator_batches No desire to have a nice api client for this. This patch also: Improve failure handling Remove unecessary code in svc script Remove duplicated on click binding Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Bug 34478: (follow-up) patroncards: cud-delete from edit-batch and manage Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Bug 34478: (follow-up) patron-cards/edit-batch: op cud-remove, cud-dedup This is about the links for Remove selected patrons, and Remove duplicates. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Bug 34478: patroncards/edit-batch: Fix for removing patrons Added a form for delete link from patron table. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Bug 34478: Add method="get" to forms without method Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Bug 34478: op =~ ^cud- everywhere This is the result of perl op_must_start_with_cud.pl Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Bug 34478: op-cud - Rename op with op-cud in templates This is the result of perl rename_op_with_op-cud.pl Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Bug 34478: Add missing CSRF token to POST forms This is the result of % perl csrf_add_missing_csrf.pl Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Bug 34862: Include messages.inc Generated using `perl add_blocking_errors.pl` Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Bug 34913: DataTables upgrade: Update CSS and option names This patch makes two categories of changes: 1. CSS changes to accommodate changes in DataTables default CSS and markup structure. I've tried to make sure all of our Koha-specific styles are still applying. This change necessitates a rebuild of staff interface CSS. 2. DataTables option names: In this version of DataTables you can't override a default which uses CamelCase (e.g. "pagingType") with one in "Hungarian" notation, e.g. "sPaginationType." Since we define many default options in prog/js/datatables.js in camel case, any template which previously used a Hungarian notation option to override the default has now been updated to use the CamelCase version. See https://datatables.net/upgrade/1.10-convert#Options for a summary of the different option name changes. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Bug 33918: Improve translation of title tags: Patron card creator This patch updates patron card creator templates so that title tags can be more easily translated. The patch also makes some minor changes to some templates to improve consistency between page title, breadcrumb navigation, and page heading. To test, apply the patch and confirm that the following pages have the correct title tags: - Tools -> Patron card creator home page - New -> Card batch - New -> Image - New -> Layout - New -> Card template - New -> Printer profile - Manage -> Card batches - Manage -> Images - Manage -> Layouts - Manage -> Card templates - Manage -> Printer profiles Signed-off-by: Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Bug 28726: Add sort1 and sort2 to patron card creator - patron search. Also adds a select all / clear all and checkboxes. Test plan: 1. start a new batch in the patron card creator (Tools -> Patron card creator -> New -> card batch) 2. click the Add patron(s) button. Observe that Category and Library are the only options. 3. Close search for patron window. 4. Apply patch. 5. click the Add patron(s) button. Observe that you can now search for patrons by their sort1 and sort2 values. 6. perform a search and observe the 'Select all | Clear all | Add selected patrons' links and button. 7. use the Select all link to select all the patrons found by the search. 8. use the Add selected patrons button to add the selected patrons to the card batch's Add by borrowernumber(s) text input field. 9. close the search for patron window. Signed-off-by: Solene Ngamga <solene.ngamga@inLibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Bug 32910: (follow-up) Replace v4 icon names with v6 This patch updates icons which are listed as having changed names in this document: https://fontawesome.com/docs/web/setup/upgrade/upgrade-from-v4 Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Bug 33410: Use template wrapper for breadcrumbs: Patron card creator This patch updates several patron card creator templates so that they use the new WRAPPER for displaying breadcrumbs. Unrelated minor change: I added <span> around a few other strings in edit-profile.tt and edit-template.tt in order to improve translatability. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Tools -> - Patron card creator - New -> - Card batch - Image - Layout - Card template - Printer profile - Manage -> - Card batches - Images - Layouts - Card templates - Printer profiles Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Bug 32254: Add 'page-section' to various tools pages This patch adds a .page-section div to various pages in the tools section in order to provide a consistent page structure. Also changed: Corrected a couple of templates which were missing some <tr> tags. This patch includes indentation changes, so please ignore whitespace when looking at the diff. To test, apply the patch and view the following pages to confirm that the primary page content is wrapped in a container with a white background: - Tools -> Access files - Tools -> HTML customizations - Additional contents, news or pages-- all use the same template. - Check the list of existing entries. - Tools -> Batch extend due dates - Choose a set of criteria that will return results and click "Continue". - Check the list of checkouts to be updated. - Tools -> Batch patron modification - Submit a batch of patrons for modification. - Check the list of patrons to be modified. - Tools -> Upload patron images - Upload one or more patron images - Check the view of results - Tools -> Upload - Upload a file and view the results, or perform a search and check the view of results. - Tools -> Patron card creator -> New patron card batch. - Submit a set of patrons and check the display of patrons in the resulting batch. - Tools -> Cash summary for <library> and Tools -> Transaction history for <register> - Confirm that the table of data looks correct Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: David <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Bug 30952: Undo change to Home breadcrumb for remaining templates Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Bug 30952: Staff interface redesign (header) What this patch does: - change the navigation bar style - change the breadcrumbs style - change the "last borrower" link style - move the search bar inside the navigation bar - move the help link to the same row as the breadcrumbs Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Bug 31352: Change 'Borrower name' to 'Patron name' Test plan: 1. Go to Tools > Patron card creator > New > Card batch 2. Enter a borrowernumber and click 'Add patron(s)' 3. Observe a table with the leftmost column name 'Borrower name' loads 4. Apply patch 5. Refresh page 6. Observe the leftmost column name is 'Patron name' Sponsored-by: Catalyst IT, New Zealand Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>