Bug 35941: Limit club list to those from the logged in user
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 30 Jan 2024 13:53:03 +0000 (14:53 +0100)
committerFrédéric Demians <f.demians@tamil.fr>
Thu, 22 Feb 2024 13:02:53 +0000 (13:02 +0000)
commit17ed4acb1711f9493daa85189f09d9beec36d90b
tree8cc49dc60ecb96ba75c942fe7d5441389312319a
parentc8eaa99e401296afc34a3816ba5faee962acb64b
Bug 35941: Limit club list to those from the logged in user

clubs-tab get the patron's id from the parameter. At the OPAC we must
use the one from the logged in user, to prevent leak to other users

Test plan:
Have 2 clubs: A, B
Enroll to A with patron borrowernumber=1
Enroll to B with patron borrowernumber=2
Log in with patron 1 and hit:
  http://localhost:8080/cgi-bin/koha/clubs/clubs-tab.pl?borrowernumber=1
=> OK
Now hit
  http://localhost:8080/cgi-bin/koha/clubs/clubs-tab.pl?borrowernumber=2
=> oops

Apply this patch, try again.
The "borrowernumber" parameter is no longer used to fetch the club list.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit e51ef7ef76a4ee523b302d724d80118185030e60)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
koha-tmpl/opac-tmpl/bootstrap/en/modules/clubs/clubs-tab.tt
koha-tmpl/opac-tmpl/bootstrap/en/modules/clubs/enroll.tt
opac/clubs/clubs-tab.pl
opac/clubs/enroll.pl