Bug 9915: (follow-up) use SQL placeholders
authorGalen Charlton <gmc@esilibrary.com>
Sun, 20 Apr 2014 16:04:27 +0000 (16:04 +0000)
committerGalen Charlton <gmc@esilibrary.com>
Sun, 20 Apr 2014 22:54:09 +0000 (22:54 +0000)
commit1931d2d22ffb2dfb2e7b8c64a3d866cc2d9f48bb
tree748f010ef4540b704024f4a9105fedf7e1ad6369
parent91619116129f37eca3088a90bb67975d8dd78301
Bug 9915: (follow-up) use SQL placeholders

This patch teaches C4::Reports::Guided::execute_query()
how to accept a list of query parameter values.  It then
follows-up on the main patch by simplifying how it converts
report parameters to a complete SQL query, and removes the
use of DBI->quote() and complicated regexes.

To test:

[1] Verify that using the OPAC svc/report service with
    sql_params continues to work.
[2] Verify that there are no regressions with running
    reports from the staff interface, both via the web
    service and the reports interface.
[3] Verify that prove -v /db_dependent/Reports_Guided.t passes.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes all tests and QA script.
No regressions found.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
C4/Reports/Guided.pm
opac/svc/report
t/db_dependent/Reports_Guided.t