Bug 13050: Follow-up for bug 12371
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Thu, 9 Oct 2014 11:09:47 +0000 (13:09 +0200)
committerTomas Cohen Arazi <tomascohen@gmail.com>
Fri, 21 Nov 2014 18:29:43 +0000 (15:29 -0300)
commit1993b3090cb1d947ec045c7dbeb10346d5c7dd27
treece14aaf414281f64a658243f13b22b4c5981a16b
parent66353372cf6d0b76b7be1024f14e91a236d0e0d3
Bug 13050: Follow-up for bug 12371

This patch simplifies the SQL query in Letters.pm for table
borrower_modifications.
It also addresses the only case this query is used in opac-memberentry.
An unused variable in Letters.pm is removed.

Test plan:
Enable selfregistration on opac.
Set verification by email to required in prefs too.
Self-register two new users.
Check the email notices generated.
Verify the new users with the tokens in their notice.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Much cleaner SQL

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Cleaner and works as described, no regressions found.
Passes tests and QA script.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
C4/Letters.pm
opac/opac-memberentry.pl