Bug 26896: Enable SIP option holds_block_checkin to actually block checkin of items...
authorKyle M Hall <kyle@bywatersolutions.com>
Mon, 2 Nov 2020 14:50:42 +0000 (09:50 -0500)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 3 Nov 2020 10:07:22 +0000 (11:07 +0100)
commit20431a03360583b705d3e2b2e3a60b2ff1f29474
tree38f2a7f58af30a02478cef7fbcad5c0ae0555908
parentfa3829b120c1909dd1a1408392c3f27479779b03
Bug 26896: Enable SIP option holds_block_checkin to actually block checkin of items with holds

It appears that at some point, the actual blocking of checkins on items
with holds got lost from the patch set. This slipped by because the sip
server still outputs everything correctly, but the unit tests don't
actually test to see if the checkout still exists afterward!

Test plan:
1) Apply this patch
2) Prove t/db_dependent/SIP/Message.t

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Matthias Meusburger <matthias.meusburger@biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
C4/SIP/ILS/Transaction/Checkin.pm
t/db_dependent/SIP/Message.t