Bug 14237: (follow-up) Make the routines exclusively take itemnumber, biblionumber...
authorNick Clemens <nick@bywatersolutions.com>
Fri, 11 Jun 2021 19:17:27 +0000 (19:17 +0000)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 12 Jul 2021 10:09:44 +0000 (12:09 +0200)
commit46f25273887948f0170c48fe405758d1d86376f0
tree2144460b53df82f1b8e98501730312da376665e7
parent5b9d11020aeb32dfa7368bbab9acd2f04557b6e5
Bug 14237: (follow-up) Make the routines exclusively take itemnumber, biblionumber, or ci_id

This patch changes the parameters for several of the CourseReserves routines to take a single
identifier exclusively.

Following the existing pattern we simply return if the params are incorrect

This patch also:
removes an unused 'title' variable
adds a prefetch to save some db calls where we fetch related objects
adjusts tests

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
C4/CourseReserves.pm
Koha/Schema/Result/CourseItem.pm
course_reserves/add_items.pl
course_reserves/batch_add_items.pl
koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/add_items-step2.tt
t/db_dependent/CourseReserves/CourseItems.t