Bug 20167: Make changing a hold pass the itemnumber to ModReserve
authorTomas Cohen Arazi <tomascohen@gmail.com>
Mon, 5 Mar 2018 16:36:50 +0000 (13:36 -0300)
committerNick Clemens <nick@bywatersolutions.com>
Thu, 15 Mar 2018 08:24:00 +0000 (08:24 +0000)
commit4f5d525d66f1436fb1a74f4fc9da3a0d17168e75
treed33e7b1f32278e9e85f8c88f699dcb22ee939c86
parent00374d0741b5c94ccdbbbc36164d4ef099ab3e2c
Bug 20167: Make changing a hold pass the itemnumber to ModReserve

If you have an item-level hold, changing an attribute (like priority,
pickup location or suspended until date) makes the hold a biblio-level
hold, because ModReserve is not passed the current itemnumber.

This patch uses the hold's itemnumber and passes it to the ModReserve
call.

To test:
- Run the regression tests from the previous patch:
  $ kshell
 k$ prove t/db_dependent/api/v1/holds.t
=> FAIL: Tests fail
- Apply this patch
- Run the tests:
  $ kshell
 k$ prove t/db_dependent/api/v1/holds.t
=> SUCCESS: Tests pass!
- Sign off :-D

Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Koha/REST/V1/Hold.pm