Bug 27707: (bug 26639 follow-up) Fix renewals when RenewalSendNotice is set
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 16 Feb 2021 08:06:03 +0000 (09:06 +0100)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 16 Feb 2021 13:51:23 +0000 (14:51 +0100)
commit76c38d10d06dfcc377ab82cd312b12b8457a2dc8
tree28d48fcff8eb001e55d0edef39d067232381a30e
parent93bc3af5a9b72d5d15a76648e9b9cd7a963bd05f
Bug 27707: (bug 26639 follow-up) Fix renewals when RenewalSendNotice is set

Since bug 26639 we have auto savepoint enabled and the LOCK TABLE query
in C4::Circulation::SendCirculationAlert is not correctly handled.
From the MySQL doc that is copied few lines before, "LOCK TABLE will
commit any transactions", but here we don't have a savepoint and the
release for a non-existent savepoint will throw a DBI exception.

This patch removes the unecessary transaction and prevent the following
error when a renewal is done:
> DBIx::Class::Storage::DBI::mysql::_exec_svp_release(): DBI Exception: DBD::mysql::db do failed: SAVEPOINT savepoint_0 does not exist [for Statement "RELEASE SAVEPOINT savepoint_0"] at /usr/share/koha/lib/C4/Circulation.pm line 3590

Test plan:
1. Enable RenewalSendNotice
2. Add some email address to patron and select the email box from the message preference "Item checkout and renewal" in order to receive renewal emails.
3. Check 1 item out to a patron
4. Renew it

Signed-off-by: Andrew Nugged <nugged@gmail.com>
Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
C4/Circulation.pm