Bug 4319: (QA follow-up) Consistency in IsAvailableForItemLevelRequest
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Fri, 15 Dec 2017 09:09:29 +0000 (10:09 +0100)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 13 Feb 2018 16:02:23 +0000 (13:02 -0300)
commit7ac45d00b6c2cabe3535ec31e901b2c6b0f6f191
treeff1dc133efccd0cd353ac266eaf6c009f86c0a16
parenta9779b67d652351c32486ffc005a01b465ec463e
Bug 4319: (QA follow-up) Consistency in IsAvailableForItemLevelRequest

[1] For consistency going back to IsItemOnHoldAndFound in this sub.
    This call is used in the on_shelf_holds == 2 case too.
    The routine will be refactored quite soon.
    Adding the else branch for on_shelf_holds == 0 for more clarity.
[2] Removing the test for found==F in reserves. In Koha F is only used
    when the hold is filled and moved to oldreserves.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
C4/Reserves.pm
t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t