Bug 14821: Do not list not returned items
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 15 Sep 2015 07:24:07 +0000 (08:24 +0100)
committerTomas Cohen Arazi <tomascohen@theke.io>
Tue, 3 Nov 2015 17:12:47 +0000 (14:12 -0300)
commit8122df1f8788cbd695e06aa4c1acfa345da8cadc
tree1a7ac768529e6eeeeacef2bf8bacf1763a82a6bb
parent1517301c38e3414c984ac09c3a072420eb8a9fdc
Bug 14821: Do not list not returned items

On the checkin page, the table is always filled with info of the scanned
barcode, even if the checkin has failed.
When the checkin fails, there is already an error displayed, so there is
no need to keep a row for fails.

Test plan:
Confirm that the failed checkins don't appear anymore in the checkin
table.
- checkin an item which is not issued;
- BlockReturnOfWithdrawnItems is set and item is withdrawn;
- Not returned at the right place;
- privacy=2 and AnonymousPatron not correctly set;

Before this patch this behavior existed only for bad barcode.

Signed-off-by: Frederic Demians <f.demians@tamil.fr>
  I confirm that the checkin table hasn't to be populated with info on items
  which haven't been checked in.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
circ/returns.pl