Bug 16481 - Report menu has unexpected issues
authorOwen Leonard <oleonard@myacpl.org>
Mon, 9 May 2016 18:23:34 +0000 (14:23 -0400)
committerKyle M Hall <kyle@bywatersolutions.com>
Mon, 16 May 2016 17:29:50 +0000 (17:29 +0000)
commit8aec387198ac589d4179064123a0f6e213efa5f1
tree373facf63baa1c2977fe9018cfc98b21b3756809
parent7f3feacfe3897affbf76531eb3abd8cbc88a81e9
Bug 16481 - Report menu has unexpected issues

This patch corrects a problem with the reports toolbar include file
which can cause a problem with the "duplicate" button. The duplicate
button passes the entire report SQL as a URL parameter, but the template
variable was not escaped as a URL variable.

This patch also adds the "uri" filter to the report name and notes
fields just to be safe.

To reproduce the bug, create a new SQL report using the SQL in the bug
report. When you run the report you should see a broken "Duplicate"
button.

Apply the patch and run the report again. The duplicate button should
look correct and work correctly.

Signed-off-by: Aleisha <aleishaamohia@hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc