Bug 16644: Plack: Use to_app to remove warning about Plack::App::CGIBin instance
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Fri, 3 Jun 2016 09:31:44 +0000 (11:31 +0200)
committerFrédéric Demians <f.demians@tamil.fr>
Mon, 1 Aug 2016 07:24:14 +0000 (09:24 +0200)
commit8b15c8328bd7a104aac0900cdf88f1670f1b0c9e
tree63825f180c051fdb1334ea508cd80feed84e96fd
parent92b4bb6f9accf87265e84e6a2d2c2993d29986b3
Bug 16644: Plack: Use to_app to remove warning about Plack::App::CGIBin instance

Using Plack with the debian psgi file, I get lots of warnings like:
WARNING: Automatically converting Plack::App::CGIBin instance to a PSGI code reference. If you see this warning for each request, you probably need to explicitly call to_app() i.e. Plack::App::CGIBin->new(...)->to_app in your PSGI file.

This patch is aimed to eliminate the warns.

Test plan:
Run Plack with plack.psgi or koha.psgi and verify if you do not see these
warnings anymore.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
I tested on Jessie and I see no regressions.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit d69d874a3f749687c2ff9a8d2a400378dfc94ff6)
Signed-off-by: Frédéric Demians <f.demians@tamil.fr>
debian/templates/plack.psgi
misc/plack/koha.psgi