Bug 25491: Fix for "Use of uninitialized value" in InstallAuth.pm
authorSlava Shishkin <slavashishkin@gmail.com>
Wed, 13 May 2020 17:20:27 +0000 (20:20 +0300)
committerVictor Grousset/tuxayo <victor@tuxayo.net>
Sun, 26 Jul 2020 15:34:12 +0000 (17:34 +0200)
commit9a64956e11b3492cfa3f57097fb6942f783805ea
tree1e303861e4f21ffc79c496364a0e2008c7dbec0a
parent4e2a8c53c3d59d5927e2f668680ba565252341c0
Bug 25491: Fix for "Use of uninitialized value" in InstallAuth.pm

This warning was thrown:
    Use of uninitialized value $info{"invalid_username_or_password"}
    in numeric eq (==) at /home/vagrant/kohaclone/C4/InstallAuth.pm
    line 387.

There is the case when hash key can be undefined in numeric comparison.

Fixed by adding additional precheck for
$info{"invalid_username_or_password"} being Perl's "true".

To test:
    1) Go to the first page of the web-installer where it asks to login.
    2) Observe the warning in the log file.
    3) Apply patch.
    4) Repeat step 1.
    7) Check that previous warning suppressed.

Mentored-by: Andrew Nugged <nugged@gmail.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit d81438e143273a538c09cd16e7f92a83beed4027)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit 3a3237da9c2f107a9d4e4a9e9383316ce10e6ecc)

Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
(cherry picked from commit 0d9ea88b86ea48142aabdb4eea6efb4b98eae3f1)
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
C4/InstallAuth.pm